public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Denys Vlasenko <dvlasenk@redhat.com>
To: "Zack Weinberg" <zackw@panix.com>
Cc: "Ian Lance Taylor" <iant@google.com>,
	        "GCC Patches" <gcc-patches@gcc.gnu.org>,
	jakub@redhat.com
Subject: Re: [PATCH] gcc cannot deal with full /tmp
Date: Mon, 04 Aug 2008 11:03:00 -0000	[thread overview]
Message-ID: <200808041302.34844.dvlasenk@redhat.com> (raw)
In-Reply-To: <eb97335b0808011451q1563cee7laa3b9497bf1379b5@mail.gmail.com>

On Friday 01 August 2008 11:51:04 pm Zack Weinberg wrote:
> On Fri, Aug 1, 2008 at 3:57 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
> [...]
> > My original approach was to reduce number of loops
> > instead of bailing out _immediately_ on errno != EEXIST.
> > I feared that otherwise I'll have to deal with
> > "obscure system XYZ throws weird errno at me" syndrome.
> >
> > This is it coming true.
> 
> I'm quite confident that EEXIST and EISDIR are the only two errno
> codes that should trigger looping.

I am confident that only EEXIST should trigger looping,
because I just tested that opening a dir with O_EXCL
returns EEXIST, not EISDIR.

I will promptly change my mind as soon as I will be bitten
by some other Unix throwing EISDIR on me.

Then, after a few years, when yet another Unix will also
bite me by throwing a ELOOP on an attempt of opening
a self-referential symlink in /tmp, I will add a check
for ELOOP too.

And so on. EFBIG, ETXTBSY, maybe even ENODEV are in store.

Or maybe I should forestall multiple iterations of fixing
of the same bug, don't you think?
--
vda

  reply	other threads:[~2008-08-04 11:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31 19:59 Zack Weinberg
2008-07-31 21:48 ` Ian Lance Taylor
2008-08-01 10:57   ` Denys Vlasenko
2008-08-01 21:51     ` Zack Weinberg
2008-08-04 11:03       ` Denys Vlasenko [this message]
2008-08-17  8:33         ` Zack Weinberg
2008-08-18 12:10           ` Denys Vlasenko
2008-08-18 12:29             ` Jakub Jelinek
2008-08-18 12:35               ` Denys Vlasenko
2008-08-18 13:24                 ` Andreas Schwab
2008-08-18 13:25                   ` Denys Vlasenko
2008-08-18 13:57                     ` Andreas Schwab
  -- strict thread matches above, loose matches on Subject: below --
2008-07-28 19:25 Denys Vlasenko
2008-07-28 20:12 ` Joseph S. Myers
2008-07-28 21:22   ` Aaron W. LaFramboise
2008-07-29 15:57 ` Ian Lance Taylor
2008-07-29 16:57   ` Jakub Jelinek
2008-07-30 14:17   ` Denys Vlasenko
2008-07-30 15:12     ` Ian Lance Taylor
2008-07-31 10:30       ` Jakub Jelinek
2008-07-31 20:15         ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808041302.34844.dvlasenk@redhat.com \
    --to=dvlasenk@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iant@google.com \
    --cc=jakub@redhat.com \
    --cc=zackw@panix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).