public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Richard Guenther" <richard.guenther@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "Manuel López-Ibáñez" <lopezibanez@gmail.com>,
	"Gcc Patch List" <gcc-patches@gcc.gnu.org>,
	"Daniel Berlin" <dberlin@dberlin.org>
Subject: Re: [PATCH] limit commit message to 500 lines (was: Please, do not use the merged revisions log as the commit message when merging)
Date: Tue, 26 Aug 2008 19:15:00 -0000	[thread overview]
Message-ID: <84fc9c000808260836y71b1df8av76ce1548be8d6472@mail.gmail.com> (raw)
Message-ID: <20080826191500.84LQG3Co19ngASS2zuhuxkOnQQzaP8tiSNLL-OuzNEc@z> (raw)
In-Reply-To: <6dc9ffc80808260806s4cdf623chadd0abf5b99349dc@mail.gmail.com>

On Tue, Aug 26, 2008 at 5:06 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Aug 26, 2008 at 7:18 AM, Manuel López-Ibáñez
> <lopezibanez@gmail.com> wrote:
>> 2008/8/16 Manuel López-Ibáñez <lopezibanez@gmail.com>:
>>> Could we put a limit to the commit log entry? More than 500 hundred
>>> lines changelog entries should just be rejected and this will avoid
>>> someone accidentally committing a full log or a diff or just random
>>> junk.
>>>
>>
>> The following patch to our pre-commit hook enables this. I have tested
>> it with a dummy repository but review from bourne-shell and/or
>> subversion knowledgeable people would be welcome.
>>
>
> When I add 600 testcases, should I mention each of them in commit log?

Yes.

IMHO 600 lines is too short.  Can't we simply detect svnmerge logs somehow?

Richard.

  parent reply	other threads:[~2008-08-26 15:50 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 16:41 Manuel López-Ibáñez
2008-08-26 16:51 ` Manuel López-Ibáñez
2008-08-26 17:13 ` Manuel López-Ibáñez
2008-08-26 17:35 ` H.J. Lu
2008-08-26 17:44   ` H.J. Lu
2008-08-26 17:47   ` Richard Guenther [this message]
2008-08-26 19:15     ` Richard Guenther
2008-08-26 19:31     ` H.J. Lu
2008-08-26 20:01       ` H.J. Lu
2008-08-26 20:58       ` Manuel López-Ibáñez
2008-08-26 22:50         ` Manuel López-Ibáñez
2008-08-27  7:41         ` Manuel López-Ibáñez
2008-08-27 11:26         ` Manuel López-Ibáñez
2008-08-27 16:10         ` Manuel López-Ibáñez
2008-08-27 22:20         ` Manuel López-Ibáñez
2008-08-27  8:08       ` H.J. Lu
2008-08-27 16:30       ` H.J. Lu
2008-08-27 23:58       ` H.J. Lu
2008-08-26 20:04     ` Richard Guenther
2008-08-26 22:09     ` Manuel López-Ibáñez
2008-08-26 23:31       ` Manuel López-Ibáñez
2008-08-27 10:40       ` Manuel López-Ibáñez
2008-08-27 18:25       ` Manuel López-Ibáñez
2008-08-27 22:09       ` Manuel López-Ibáñez
2008-08-27  0:42     ` Richard Guenther
2008-08-27  7:54     ` Manuel López-Ibáñez
2008-08-27 18:15       ` Manuel López-Ibáñez
2008-08-27 12:51     ` Richard Guenther
2008-08-27 18:36     ` Richard Guenther
2008-08-27 20:45     ` Richard Guenther
2008-08-26 17:56   ` H.J. Lu
2008-08-26 20:19   ` H.J. Lu
2008-08-26 20:49   ` Manuel López-Ibáñez
2008-08-26 21:53     ` H.J. Lu
2008-08-27  0:54       ` H.J. Lu
2008-08-27  4:21       ` Manuel López-Ibáñez
2008-08-27  8:02         ` Manuel López-Ibáñez
2008-08-27  9:00         ` Manuel López-Ibáñez
2008-08-27 13:54         ` H.J. Lu
2008-08-27 14:46           ` Manuel López-Ibáñez
2008-08-27 15:41             ` H.J. Lu
2008-08-27 16:33               ` H.J. Lu
2008-08-27 19:55               ` H.J. Lu
2008-08-27 20:27               ` Daniel Berlin
2008-08-27 22:20               ` H.J. Lu
2008-08-27 16:10             ` Manuel López-Ibáñez
2008-08-27 17:50             ` Manuel López-Ibáñez
2008-08-27 18:45             ` Manuel López-Ibáñez
2008-08-27 21:54             ` Manuel López-Ibáñez
2008-08-27 16:13           ` H.J. Lu
2008-08-27 18:40           ` H.J. Lu
2008-08-27 20:17           ` Daniel Berlin
2008-08-27 20:44             ` Daniel Berlin
2008-08-27 20:48           ` H.J. Lu
2008-08-27 16:46         ` Manuel López-Ibáñez
2008-08-27 18:24         ` Manuel López-Ibáñez
2008-08-27 20:34         ` Manuel López-Ibáñez
2008-08-27 12:01       ` H.J. Lu
2008-08-27 19:43       ` H.J. Lu
2008-08-27 22:59       ` H.J. Lu
2008-08-26 22:21     ` Manuel López-Ibáñez
2008-08-27  6:19     ` Manuel López-Ibáñez
2008-08-27 13:36     ` Manuel López-Ibáñez
2008-08-27 17:47     ` Manuel López-Ibáñez
2008-08-27 18:25     ` Manuel López-Ibáñez
2008-08-27 22:20     ` Manuel López-Ibáñez
2008-08-27 11:26   ` H.J. Lu
2008-08-26 17:37 ` Manuel López-Ibáñez
2008-08-26 20:22 ` Manuel López-Ibáñez
     [not found] ` <1219764262.13055.58.camel@localhost>
2008-08-26 20:47   ` Manuel López-Ibáñez
2008-08-26 22:35     ` Manuel López-Ibáñez
2008-08-27  4:35     ` Manuel López-Ibáñez
2008-08-27  8:27     ` Manuel López-Ibáñez
2008-08-27 15:12     ` Paolo Bonzini
2008-08-27 16:22       ` Paolo Bonzini
2008-08-27 19:30       ` Paolo Bonzini
2008-08-27 19:46       ` Manuel López-Ibáñez
2008-08-27 20:07         ` Manuel López-Ibáñez
2008-08-27 20:32         ` Manuel López-Ibáñez
2008-08-27 22:26       ` Paolo Bonzini
2008-08-27 17:35     ` Manuel López-Ibáñez
2008-08-27 19:57     ` Manuel López-Ibáñez
2008-08-27 22:22     ` Manuel López-Ibáñez
2008-08-27 14:03 ` Manuel López-Ibáñez
2008-08-27 16:31 ` Manuel López-Ibáñez
2008-08-27 22:48 ` Manuel López-Ibáñez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84fc9c000808260836y71b1df8av76ce1548be8d6472@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=dberlin@dberlin.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=lopezibanez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).