From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16638 invoked by alias); 12 Sep 2008 13:32:16 -0000 Received: (qmail 16616 invoked by uid 22791); 12 Sep 2008 13:32:14 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 12 Sep 2008 13:31:30 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m8CDTBJ3515064 for ; Fri, 12 Sep 2008 13:29:11 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m8CDTB7k3928138 for ; Fri, 12 Sep 2008 15:29:11 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m8CDT7lF031811 for ; Fri, 12 Sep 2008 15:29:07 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m8CDT7rk031804; Fri, 12 Sep 2008 15:29:07 +0200 Message-Id: <200809121329.m8CDT7rk031804@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 12 Sep 2008 15:29:07 +0200 Subject: Re: [PATCH, SPU] generated better code for loads and stores To: Trevor_Smigiel@playstation.sony.com Date: Fri, 12 Sep 2008 14:24:00 -0000 From: "Ulrich Weigand" Cc: gcc-patches@gcc.gnu.org (gcc-patches), andrew_pinski@playstation.sony.com, rguenther@suse.de In-Reply-To: <20080911231841.GM6066@playstation.sony.com> from "Trevor_Smigiel@playstation.sony.com" at Sep 11, 2008 04:18:41 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-09/txt/msg00962.txt.bz2 Trevor, > After split0 every address must satisfy LEGITIMATE_ADDRESS. I can't > think of a test case off the top of my head, but it is better to be safe > and make sure the address is valid. The code after this that changes > the load to TImode forces it to be valid. I had assumed that if the address passed the tests in spu_split_load up to this point, and no rotate was required, the address *must* be legitimate ... But in any case, adding a check certainly cannot hurt. > Also, the floating point neg patterns might benefit from being split > later. > > I'll merge your changes into my patch, retest and resubmit. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com