From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25909 invoked by alias); 28 Oct 2008 18:42:06 -0000 Received: (qmail 25897 invoked by uid 22791); 28 Oct 2008 18:42:05 -0000 X-Spam-Check-By: sourceware.org Received: from e6.ny.us.ibm.com (HELO e6.ny.us.ibm.com) (32.97.182.146) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 28 Oct 2008 18:41:19 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m9SIhqFN001292 for ; Tue, 28 Oct 2008 14:43:52 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9SIevwE114918 for ; Tue, 28 Oct 2008 14:40:57 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9SIeuuf020746 for ; Tue, 28 Oct 2008 14:40:56 -0400 Received: from hungry-tiger.westford.ibm.com (hungry-tiger.westford.ibm.com [9.33.20.119]) by d01av01.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m9SIeujC020735; Tue, 28 Oct 2008 14:40:56 -0400 Received: by hungry-tiger.westford.ibm.com (Postfix, from userid 500) id 2D61F1EE90A; Tue, 28 Oct 2008 14:40:55 -0400 (EDT) Date: Tue, 28 Oct 2008 21:43:00 -0000 From: Michael Meissner To: Jakub Jelinek Cc: Michael Meissner , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix combiner issues with shifts (PR c/37924, take 2) Message-ID: <20081028184055.GA2045@hungry-tiger.westford.ibm.com> Mail-Followup-To: Michael Meissner , Jakub Jelinek , gcc-patches@gcc.gnu.org References: <20081027200207.GU14706@tyan-ft48-01.lab.bos.redhat.com> <20081027211320.GA23056@hungry-tiger.westford.ibm.com> <20081027212242.GW14706@tyan-ft48-01.lab.bos.redhat.com> <20081027212638.GA32135@hungry-tiger.westford.ibm.com> <20081028112718.GZ14706@tyan-ft48-01.lab.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081028112718.GZ14706@tyan-ft48-01.lab.bos.redhat.com> User-Agent: Mutt/1.4.2.2i X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-10/txt/msg01215.txt.bz2 On Tue, Oct 28, 2008 at 12:27:18PM +0100, Jakub Jelinek wrote: > On Mon, Oct 27, 2008 at 05:26:38PM -0400, Michael Meissner wrote: > > On Mon, Oct 27, 2008 at 10:22:42PM +0100, Jakub Jelinek wrote: > > > On Mon, Oct 27, 2008 at 05:13:20PM -0400, Michael Meissner wrote: > > > > However, your test code should declare a to be > > > > signed char instead of char, since there are platforms where chars are unsigned > > > > by default. > > > > > > I'm aware of that, that's why I've tested the testcase works with both > > > -fsigned-char and -funsigned-char. I wanted to cover both signed char > > > (on some arches) and unsigned char (on others). > > > > I was just picking up on whether storing 0x80 would someday cause the test to > > fail on different signed/unsigned char configurations (since 0x80 can't be fit > > in a normal char), and I figured it was better to write type correct code to > > have the meaning clear. > > Ok, here is the same patch with testcase that tests both signed char and > unsigned char on all targets. Bootstrapped/regtested on x86_64-linux, ok > for trunk? Ok. -- Michael Meissner, IBM 4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA meissner@linux.vnet.ibm.com