From: Jakub Jelinek <jakub@redhat.com>
To: Janis Johnson <janis187@us.ibm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: [PATCH] Fix g++.dg/abi/key2.C testcase on darwin (PR testsuite/37241)
Date: Mon, 03 Nov 2008 20:30:00 -0000 [thread overview]
Message-ID: <20081103202919.GM14706@tyan-ft48-01.lab.bos.redhat.com> (raw)
Hi!
This testcase fails since -O0 went to -funit-at-a-time
-fno-toplevel-reorder, as the _ZT{V,S,I}* objects are now emitted
in different order and __ZT{V,I}* which are in the same section
now use just one .section directive instead of 2, when __ZTS* was
emitted in between them.
Tested by Dominique, ok for trunk?
2008-11-03 Jakub Jelinek <jakub@redhat.com>
PR testsuite/37241
* g++.dg/abi/key2.C: Adjust regexps to allow __ZTV1f and __ZTI1f
sharing one .section directive.
--- gcc/testsuite/g++.dg/abi/key2.C.jj 2008-09-05 12:55:05.000000000 +0200
+++ gcc/testsuite/g++.dg/abi/key2.C 2008-11-03 12:53:16.000000000 +0100
@@ -2,9 +2,9 @@
// PR darwin/25908
// { dg-do compile { target *-*-darwin* } }
-// { dg-final { scan-assembler ".globl __ZTV1f\\n .weak_definition __ZTV1f\\n .section __DATA,__const_coal,coalesced" } }
+// { dg-final { scan-assembler ".globl __ZTV1f\\n .weak_definition __ZTV1f(\\n .section __DATA,__const_coal,coalesced)?\\n .align" } }
// { dg-final { scan-assembler ".globl __ZTS1f\\n .weak_definition __ZTS1f\\n .section __TEXT,__const_coal,coalesced" } }
-// { dg-final { scan-assembler ".globl __ZTI1f\\n .weak_definition __ZTI1f\\n .section __DATA,__const_coal,coalesced" } }
+// { dg-final { scan-assembler ".globl __ZTI1f\\n .weak_definition __ZTI1f(\\n .section __DATA,__const_coal,coalesced)?\\n .align" } }
class f
{
Jakub
next reply other threads:[~2008-11-03 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 20:30 Jakub Jelinek [this message]
2008-11-03 20:55 ` Janis Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081103202919.GM14706@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janis187@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).