public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Diego Novillo <dnovillo@google.com>
Cc: Jan Hubicka <hubicka@ucw.cz>,
	Rafael Espindola <espindola@google.com>,
		gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [lto][patch] Move the call to execute_all_ipa_transforms to  	cgraphunit.c
Date: Wed, 12 Nov 2008 00:04:00 -0000	[thread overview]
Message-ID: <20081111235839.GJ27401@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <b798aad50811111555y41369e40s42ededc70689c5c7@mail.gmail.com>

> On Tue, Nov 11, 2008 at 18:52, Jan Hubicka <hubicka@ucw.cz> wrote:
> 
> > It seems that most correct approach would be to turn extern inline
> > functions into static functions before LTO and have pass that will
> > redirect the calls of noninlined bodies to the non-extern inline body
> > (or external call) after inlining.  This way we don't lose
> > optimization/information.
> 
> Isn't this what the inliner does already?

No, currently we handle extern inline in quite hackish way.  If there is
only extern inline function than we handle is as normal inline with the
difference that body is removed afterwards.
If there is more than one occurence of extern inline (in --combine) or
both extern inline and offline variant (this can be in single C unit),
then we simply disable inlining and panic.
This is all because of DECL sharing, I was never able to get multiple
variants of same function out of C and C++ frontend.

Honza
> 
> 
> Diego.

  reply	other threads:[~2008-11-11 23:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11 17:31 Rafael Espindola
2008-11-11 20:23 ` Jan Hubicka
2008-11-11 22:49   ` Rafael Espindola
2008-11-11 22:53     ` Jan Hubicka
2008-11-11 23:11   ` Diego Novillo
2008-11-11 23:18     ` Jan Hubicka
2008-11-11 23:41       ` Rafael Espindola
2008-11-11 23:59         ` Jan Hubicka
2008-11-12  0:01           ` Diego Novillo
2008-11-12  0:04             ` Jan Hubicka [this message]
2008-11-12  0:57               ` Jan Hubicka
2008-11-12  2:02                 ` Diego Novillo
2008-11-12 10:01                   ` Rafael Espindola
2008-11-12 16:02                     ` Jan Hubicka
2008-11-12 16:35                   ` Jan Hubicka
2008-11-11 23:53       ` Diego Novillo
2008-11-11 22:54 ` Diego Novillo
2008-11-11 23:14   ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081111235839.GJ27401@atrey.karlin.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=dnovillo@google.com \
    --cc=espindola@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).