Re: [lto][patch] Move the call to execute_all_ipa_transforms to cgraphunit.c

[Jan Hubicka <jh@suse.cz>]

> > On Tue, Nov 11, 2008 at 18:52, Jan Hubicka <hubicka@ucw.cz> wrote:
> > 
> > > It seems that most correct approach would be to turn extern inline
> > > functions into static functions before LTO and have pass that will
> > > redirect the calls of noninlined bodies to the non-extern inline body
> > > (or external call) after inlining.  This way we don't lose
> > > optimization/information.
> > 
> > Isn't this what the inliner does already?
> 
> No, currently we handle extern inline in quite hackish way.  If there is
> only extern inline function than we handle is as normal inline with the
> difference that body is removed afterwards.
> If there is more than one occurence of extern inline (in --combine) or
> both extern inline and offline variant (this can be in single C unit),
> then we simply disable inlining and panic.
> This is all because of DECL sharing, I was never able to get multiple
> variants of same function out of C and C++ frontend.

... also extern inline functions remain extern for most of IPA stuff as
well as --combine merging that is quite suboptimal.
I guess we don't need to care about --combine, but the case where both
extern inline and offline is in one unit seems quite important
implementation quality bug to me.

Honza
> 
> Honza
> > 
> > 
> > Diego.