* [PATCH, AVR,Committed] Add support for new devices
@ 2008-11-12 20:31 Anatoly Sokolov
2008-11-12 20:50 ` Michael Meissner
0 siblings, 1 reply; 7+ messages in thread
From: Anatoly Sokolov @ 2008-11-12 20:31 UTC (permalink / raw)
To: gcc-patches; +Cc: eweddington, aesok
Hi.
The attached patch to add support for the new AVR device in GCC.
2008-11-12 Anatoly Sokolov <aesok@post.ru>
* config/avr/avr.c (avr_mcu_t): Add atmega16hvb, atmega32hvb,
atmega4hvd, atmega8hvd, atmega64c1, atmega64m1, atmega16u4 and
atmega32u6 devices.
* config/avr/avr.h (LINK_SPEC, CRT_BINUTILS_SPECS): (Ditto.).
* config/avr/t-avr (MULTILIB_MATCHES): (Ditto.).
Index: gcc/config/avr/avr.h
===================================================================
--- gcc/config/avr/avr.h (revision 141795)
+++ gcc/config/avr/avr.h (working copy)
@@ -840,7 +840,7 @@
mmcu=at90usb162|\
mmcu=attiny167: -m avr3}\
%{mmcu=atmega8*|\
- mmcu=atmega48*|\
+ mmcu=atmega4*|\
mmcu=at90pwm1|\
mmcu=at90pwm2|\
mmcu=at90pwm2b|\
@@ -876,16 +876,21 @@
mmcu=atmega165*|\
mmcu=atmega168*|\
mmcu=atmega169*|\
- mmcu=atmega8hva|\
- mmcu=atmega16hva|\
+ mmcu=atmega4hv*|\
+ mmcu=atmega8hv*|\
+ mmcu=atmega16hv*|\
+ mmcu=atmega32hv*|\
mmcu=attiny48|\
mmcu=attiny88|\
mmcu=attiny167|\
mmcu=at90can*|\
mmcu=at90pwm*|\
mmcu=atmega32c1|\
+ mmcu=atmega64c1|\
mmcu=atmega32m1|\
- mmcu=atmega32u4|\
+ mmcu=atmega64m1|\
+ mmcu=atmega16u4|\
+ mmcu=atmega32u*|\
mmcu=at90usb*: -Tdata 0x800100}\
%{mmcu=atmega640|\
mmcu=atmega1280|\
@@ -992,13 +997,21 @@
%{mmcu=atmega6490:crtm6490.o%s} \
%{mmcu=atmega8hva:crtm8hva.o%s} \
%{mmcu=atmega16hva:crtm16hva.o%s} \
+%{mmcu=atmega16hvb:crtm16hvb.o%s} \
+%{mmcu=atmega32hvb:crtm32hvb.o%s} \
+%{mmcu=atmega4hvd:crtm4hvd.o%s} \
+%{mmcu=atmega8hvd:crtm8hvd.o%s} \
%{mmcu=at90can32:crtcan32.o%s} \
%{mmcu=at90can64:crtcan64.o%s} \
%{mmcu=at90pwm216:crt90pwm216.o%s} \
%{mmcu=at90pwm316:crt90pwm316.o%s} \
%{mmcu=atmega32c1:crtm32c1.o%s} \
+%{mmcu=atmega64c1:crtm64c1.o%s} \
%{mmcu=atmega32m1:crtm32m1.o%s} \
+%{mmcu=atmega64m1:crtm64m1.o%s} \
+%{mmcu=atmega16u4:crtm16u4.o%s} \
%{mmcu=atmega32u4:crtm32u4.o%s} \
+%{mmcu=atmega32u6:crtm32u6.o%s} \
%{mmcu=at90usb646:crtusb646.o%s} \
%{mmcu=at90usb647:crtusb647.o%s} \
%{mmcu=at94k:crtat94k.o%s} \
Index: gcc/config/avr/avr.c
===================================================================
--- gcc/config/avr/avr.c (revision 141795)
+++ gcc/config/avr/avr.c (working copy)
@@ -214,6 +214,8 @@
{ "atmega8515", ARCH_AVR4, "__AVR_ATmega8515__" },
{ "atmega8535", ARCH_AVR4, "__AVR_ATmega8535__" },
{ "atmega8hva", ARCH_AVR4, "__AVR_ATmega8HVA__" },
+ { "atmega4hvd", ARCH_AVR4, "__AVR_ATmega4HVD__" },
+ { "atmega8hvd", ARCH_AVR4, "__AVR_ATmega8HVD__" },
{ "at90pwm1", ARCH_AVR4, "__AVR_AT90PWM1__" },
{ "at90pwm2", ARCH_AVR4, "__AVR_AT90PWM2__" },
{ "at90pwm2b", ARCH_AVR4, "__AVR_AT90PWM2B__" },
@@ -254,13 +256,19 @@
{ "atmega649", ARCH_AVR5, "__AVR_ATmega649__" },
{ "atmega6490", ARCH_AVR5, "__AVR_ATmega6490__" },
{ "atmega16hva", ARCH_AVR5, "__AVR_ATmega16HVA__" },
+ { "atmega16hvb", ARCH_AVR5, "__AVR_ATmega16HVB__" },
+ { "atmega32hvb", ARCH_AVR5, "__AVR_ATmega32HVB__" },
{ "at90can32", ARCH_AVR5, "__AVR_AT90CAN32__" },
{ "at90can64", ARCH_AVR5, "__AVR_AT90CAN64__" },
{ "at90pwm216", ARCH_AVR5, "__AVR_AT90PWM216__" },
{ "at90pwm316", ARCH_AVR5, "__AVR_AT90PWM316__" },
+ { "atmega32c1", ARCH_AVR5, "__AVR_ATmega32C1__" },
+ { "atmega64c1", ARCH_AVR5, "__AVR_ATmega64C1__" },
{ "atmega32m1", ARCH_AVR5, "__AVR_ATmega32M1__" },
- { "atmega32c1", ARCH_AVR5, "__AVR_ATmega32C1__" },
+ { "atmega64m1", ARCH_AVR5, "__AVR_ATmega64M1__" },
+ { "atmega16u4", ARCH_AVR5, "__AVR_ATmega16U4__" },
{ "atmega32u4", ARCH_AVR5, "__AVR_ATmega32U4__" },
+ { "atmega32u6", ARCH_AVR5, "__AVR_ATmega32U6__" },
{ "at90usb646", ARCH_AVR5, "__AVR_AT90USB646__" },
{ "at90usb647", ARCH_AVR5, "__AVR_AT90USB647__" },
{ "at94k", ARCH_AVR5, "__AVR_AT94K__" },
Index: gcc/config/avr/t-avr
===================================================================
--- gcc/config/avr/t-avr (revision 141795)
+++ gcc/config/avr/t-avr (working copy)
@@ -73,6 +73,8 @@
mmcu?avr4=mmcu?atmega88 \
mmcu?avr4=mmcu?atmega88p \
mmcu?avr4=mmcu?atmega8hva \
+ mmcu?avr4=mmcu?atmega4hvd \
+ mmcu?avr4=mmcu?atmega8hvd \
mmcu?avr4=mmcu?at90pwm1 \
mmcu?avr4=mmcu?at90pwm2 \
mmcu?avr4=mmcu?at90pwm2b \
@@ -111,13 +113,19 @@
mmcu?avr5=mmcu?atmega649 \
mmcu?avr5=mmcu?atmega6490 \
mmcu?avr5=mmcu?atmega16hva \
+ mmcu?avr5=mmcu?atmega16hvb \
+ mmcu?avr5=mmcu?atmega32hvb \
mmcu?avr5=mmcu?at90can32 \
mmcu?avr5=mmcu?at90can64 \
mmcu?avr5=mmcu?at90pwm216 \
mmcu?avr5=mmcu?at90pwm316 \
mmcu?avr5=mmcu?atmega32c1 \
+ mmcu?avr5=mmcu?atmega64c1 \
mmcu?avr5=mmcu?atmega32m1 \
+ mmcu?avr5=mmcu?atmega64m1 \
+ mmcu?avr5=mmcu?atmega16u4 \
mmcu?avr5=mmcu?atmega32u4 \
+ mmcu?avr5=mmcu?atmega32u6 \
mmcu?avr5=mmcu?at90usb646 \
mmcu?avr5=mmcu?at90usb647 \
mmcu?avr5=mmcu?at94k \
Anatoliy.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH, AVR,Committed] Add support for new devices
2008-11-12 20:31 [PATCH, AVR,Committed] Add support for new devices Anatoly Sokolov
@ 2008-11-12 20:50 ` Michael Meissner
2008-11-25 22:50 ` [PATCH, AVR, wwwdocs] " Weddington, Eric
0 siblings, 1 reply; 7+ messages in thread
From: Michael Meissner @ 2008-11-12 20:50 UTC (permalink / raw)
To: Anatoly Sokolov; +Cc: gcc-patches, eweddington
On Wed, Nov 12, 2008 at 11:16:44PM +0300, Anatoly Sokolov wrote:
> Hi.
>
> The attached patch to add support for the new AVR device in GCC.
>
>
> 2008-11-12 Anatoly Sokolov <aesok@post.ru>
>
> * config/avr/avr.c (avr_mcu_t): Add atmega16hvb, atmega32hvb,
> atmega4hvd, atmega8hvd, atmega64c1, atmega64m1, atmega16u4 and
> atmega32u6 devices.
> * config/avr/avr.h (LINK_SPEC, CRT_BINUTILS_SPECS): (Ditto.).
> * config/avr/t-avr (MULTILIB_MATCHES): (Ditto.).
It might be helpful to your users to also update the documentation for the new
devices you added (unless the documentation patch was done in a different
patch).
--
Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA
meissner@linux.vnet.ibm.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH, AVR, wwwdocs] Add support for new devices
2008-11-12 20:50 ` Michael Meissner
@ 2008-11-25 22:50 ` Weddington, Eric
2008-11-26 16:50 ` Michael Meissner
2008-11-30 17:50 ` Gerald Pfeifer
0 siblings, 2 replies; 7+ messages in thread
From: Weddington, Eric @ 2008-11-25 22:50 UTC (permalink / raw)
To: Michael Meissner, Anatoly Sokolov; +Cc: gcc-patches
> -----Original Message-----
> From: Michael Meissner [mailto:meissner@linux.vnet.ibm.com]
> Sent: Wednesday, November 12, 2008 1:20 PM
> To: Anatoly Sokolov
> Cc: gcc-patches@gcc.gnu.org; Weddington, Eric
> Subject: Re: [PATCH, AVR,Committed] Add support for new devices
>
> On Wed, Nov 12, 2008 at 11:16:44PM +0300, Anatoly Sokolov wrote:
> > Hi.
> >
> > The attached patch to add support for the new AVR device in GCC.
> >
> >
> > 2008-11-12 Anatoly Sokolov <aesok@post.ru>
> >
> > * config/avr/avr.c (avr_mcu_t): Add atmega16hvb,
> atmega32hvb,
> > atmega4hvd, atmega8hvd, atmega64c1, atmega64m1,
> atmega16u4 and
> > atmega32u6 devices.
> > * config/avr/avr.h (LINK_SPEC, CRT_BINUTILS_SPECS):
> (Ditto.).
> > * config/avr/t-avr (MULTILIB_MATCHES): (Ditto.).
>
> It might be helpful to your users to also update the
> documentation for the new
> devices you added (unless the documentation patch was done in
> a different
> patch).
Which documentation are you referring to? The "AVR Options" section in invoke.texi needs a giant overhaul if we are to list every single device available to the end user. I'm certainly not against doing that though.
Here is a patch for the 4.4 Changes web page:
Index: htdocs/gcc-4.4/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.4/changes.html,v
retrieving revision 1.41
diff -u -p -r1.41 changes.html
--- htdocs/gcc-4.4/changes.html 19 Nov 2008 17:06:08 -0000 1.41
+++ htdocs/gcc-4.4/changes.html 25 Nov 2008 21:15:55 -0000
@@ -319,6 +319,14 @@
<li>ATmega32C1</li>
<li>ATmega32M1</li>
<li>ATmega32U4</li>
+ <li>ATmega16HVB</li>
+ <li>ATmega32HVB</li>
+ <li>ATmega4HVD</li>
+ <li>ATmega8HVD</li>
+ <li>ATmega64C1</li>
+ <li>ATmega64M1</li>
+ <li>ATmega16U4</li>
+ <li>ATmega32U6</li>
</ul>
</li>
<li>Removed support for the AVR device ATmega32HVB.</li>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH, AVR, wwwdocs] Add support for new devices
2008-11-25 22:50 ` [PATCH, AVR, wwwdocs] " Weddington, Eric
@ 2008-11-26 16:50 ` Michael Meissner
2008-11-30 17:50 ` Gerald Pfeifer
1 sibling, 0 replies; 7+ messages in thread
From: Michael Meissner @ 2008-11-26 16:50 UTC (permalink / raw)
To: Weddington, Eric; +Cc: Michael Meissner, Anatoly Sokolov, gcc-patches
On Tue, Nov 25, 2008 at 02:21:11PM -0700, Weddington, Eric wrote: Which
> documentation are you referring to? The "AVR Options" section in invoke.texi
> needs a giant overhaul if we are to list every single device available to the
> end user. I'm certainly not against doing that though.
It was more of an observation that if you add new switches, you probably should
update the documentation, so that users can know about it without having to
dive into the source. I didn't see any update to the documentation files in
doc/options.texi, hence my comment.
--
Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA
meissner@linux.vnet.ibm.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH, AVR, wwwdocs] Add support for new devices
2008-11-25 22:50 ` [PATCH, AVR, wwwdocs] " Weddington, Eric
2008-11-26 16:50 ` Michael Meissner
@ 2008-11-30 17:50 ` Gerald Pfeifer
2008-11-30 18:56 ` Weddington, Eric
1 sibling, 1 reply; 7+ messages in thread
From: Gerald Pfeifer @ 2008-11-30 17:50 UTC (permalink / raw)
To: Weddington, Eric; +Cc: Michael Meissner, Anatoly Sokolov, gcc-patches
On Tue, 25 Nov 2008, Weddington, Eric wrote:
> Here is a patch for the 4.4 Changes web page:
Thanks, I share Michael's feeling this is good information and suggest
to commit this patch. (As ports maintainer, you are more than welcome
to make this kind of changes without any approval.)
Gerald
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH, AVR, wwwdocs] Add support for new devices
2008-11-30 17:50 ` Gerald Pfeifer
@ 2008-11-30 18:56 ` Weddington, Eric
2008-11-30 21:57 ` Anatoly Sokolov
0 siblings, 1 reply; 7+ messages in thread
From: Weddington, Eric @ 2008-11-30 18:56 UTC (permalink / raw)
To: Gerald Pfeifer; +Cc: Michael Meissner, Anatoly Sokolov, gcc-patches
> -----Original Message-----
> From: Gerald Pfeifer [mailto:gerald@pfeifer.com]
> Sent: Sunday, November 30, 2008 8:49 AM
> To: Weddington, Eric
> Cc: Michael Meissner; Anatoly Sokolov; gcc-patches@gcc.gnu.org
> Subject: RE: [PATCH, AVR, wwwdocs] Add support for new devices
>
> On Tue, 25 Nov 2008, Weddington, Eric wrote:
> > Here is a patch for the 4.4 Changes web page:
>
> Thanks, I share Michael's feeling this is good information and suggest
> to commit this patch. (As ports maintainer, you are more than welcome
> to make this kind of changes without any approval.)
I would certainly like to be an AVR port maintainer eventually. However, we (Atmel) are still waiting to finalize our copyright paperwork with FSF (which we hope to do in the next couple of weeks). Anatoliy is an AVR port maintainer, so either he would have to make the commit or someone else will have to.
Eric Weddington
Atmel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH, AVR, wwwdocs] Add support for new devices
2008-11-30 18:56 ` Weddington, Eric
@ 2008-11-30 21:57 ` Anatoly Sokolov
0 siblings, 0 replies; 7+ messages in thread
From: Anatoly Sokolov @ 2008-11-30 21:57 UTC (permalink / raw)
To: Weddington, Eric, Gerald Pfeifer; +Cc: Michael Meissner, gcc-patches
Hi.
> Anatoliy is an AVR port maintainer, so either he would have to make the commit or someone else will have to.
Commited as:
Index: htdocs/gcc-4.4/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.4/changes.html,v
retrieving revision 1.41
diff -u -r1.41 changes.html
--- htdocs/gcc-4.4/changes.html 19 Nov 2008 17:06:08 -0000 1.41
+++ htdocs/gcc-4.4/changes.html 30 Nov 2008 19:50:33 -0000
@@ -319,9 +319,15 @@
<li>ATmega32C1</li>
<li>ATmega32M1</li>
<li>ATmega32U4</li>
+ <li>ATmega16HVB</li>
+ <li>ATmega4HVD</li>
+ <li>ATmega8HVD</li>
+ <li>ATmega64C1</li>
+ <li>ATmega64M1</li>
+ <li>ATmega16U4</li>
+ <li>ATmega32U6</li>
</ul>
</li>
- <li>Removed support for the AVR device ATmega32HVB.</li>
</ul>
<h3>IA-32/x86-64</h3>
Anatoly.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-11-30 19:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-12 20:31 [PATCH, AVR,Committed] Add support for new devices Anatoly Sokolov
2008-11-12 20:50 ` Michael Meissner
2008-11-25 22:50 ` [PATCH, AVR, wwwdocs] " Weddington, Eric
2008-11-26 16:50 ` Michael Meissner
2008-11-30 17:50 ` Gerald Pfeifer
2008-11-30 18:56 ` Weddington, Eric
2008-11-30 21:57 ` Anatoly Sokolov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).