* [PATCH] build system: gcc_cv_libc_provides_ssp [not found] <20081008095357.GH7127@fencepost.gnu.org> @ 2008-10-10 10:09 ` Thomas Schwinge 2008-10-10 14:43 ` Paolo Bonzini 2008-11-14 3:47 ` Thomas Schwinge 0 siblings, 2 replies; 6+ messages in thread From: Thomas Schwinge @ 2008-10-10 10:09 UTC (permalink / raw) To: jakub, gcc-patches; +Cc: bug-hurd, debian-bsd [-- Attachment #1: Type: text/plain, Size: 1369 bytes --] Hello! On Wed, Oct 08, 2008 at 11:53:57AM +0200, I wrote: > First, the check for gcc_cv_libc_provides_ssp is not complete, as has > already pointed out (with patches!) before, but is still not fixed on > trunk. Let me revisit that: in configure.ac it is being checked for > ``case "$target" in *-*-linux*)'' which should rather match ``*-*-linux* > | *-*-*-gnu* | *-*-gnu*'' to catch all GNU/Linux, GNU/Hurd, GNU/k*BSD > systems. (This is being patched in the Debian GCC package for some time > already.) Even though the NATIVE_SYSTEM_HEADER_DIR issue is still being discussed, in either way we'll need this patch installed. Any objections? 2008-10-10 Thomas Schwinge <tschwinge@gnu.org> * configure.ac (gcc_cv_libc_provides_ssp): Also consider GNU/kFreeBSD, GNU/kNetBSD and GNU/Hurd systems. Index: configure.ac =================================================================== --- configure.ac (Revision 141003) +++ configure.ac (Arbeitskopie) @@ -3469,7 +3469,7 @@ gcc_cv_libc_provides_ssp, [gcc_cv_libc_provides_ssp=no case "$target" in - *-*-linux*) + *-*-linux* | *-*-kfreebsd*-gnu | *-*-knetbsd*-gnu | *-*-gnu*) if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then if test "x$with_sysroot" = x; then glibc_header_dir="${exec_prefix}/${target_noncanonical}/sys-include" Regards, Thomas [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 191 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] build system: gcc_cv_libc_provides_ssp 2008-10-10 10:09 ` [PATCH] build system: gcc_cv_libc_provides_ssp Thomas Schwinge @ 2008-10-10 14:43 ` Paolo Bonzini 2008-10-10 15:01 ` Paolo Bonzini 2008-11-14 3:47 ` Thomas Schwinge 1 sibling, 1 reply; 6+ messages in thread From: Paolo Bonzini @ 2008-10-10 14:43 UTC (permalink / raw) To: Thomas Schwinge; +Cc: jakub, gcc-patches, bug-hurd, debian-bsd > Even though the NATIVE_SYSTEM_HEADER_DIR issue is still being discussed, > in either way we'll need this patch installed. Any objections? Ok. But can you please create a PR and attach there all patches that I approve, but must wait until after your copyright assignment form will have been processed? Paolo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] build system: gcc_cv_libc_provides_ssp 2008-10-10 14:43 ` Paolo Bonzini @ 2008-10-10 15:01 ` Paolo Bonzini 0 siblings, 0 replies; 6+ messages in thread From: Paolo Bonzini @ 2008-10-10 15:01 UTC (permalink / raw) To: gcc-patches; +Cc: debian-bsd, bug-hurd, gcc-patches, bug-hurd > Even though the NATIVE_SYSTEM_HEADER_DIR issue is still being discussed, > in either way we'll need this patch installed. Any objections? Ok. But can you please create a PR and attach there all patches that I approve, but must wait until after your copyright assignment form will have been processed? Paolo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] build system: gcc_cv_libc_provides_ssp 2008-10-10 10:09 ` [PATCH] build system: gcc_cv_libc_provides_ssp Thomas Schwinge 2008-10-10 14:43 ` Paolo Bonzini @ 2008-11-14 3:47 ` Thomas Schwinge 2008-11-14 7:30 ` Paolo Bonzini 1 sibling, 1 reply; 6+ messages in thread From: Thomas Schwinge @ 2008-11-14 3:47 UTC (permalink / raw) To: jakub, gcc-patches, Paolo Bonzini; +Cc: bug-hurd, debian-bsd [-- Attachment #1: Type: text/plain, Size: 2105 bytes --] Hello! On Fri, Oct 10, 2008 at 10:56:34AM +0200, I wrote: > On Wed, Oct 08, 2008 at 11:53:57AM +0200, I wrote: > > First, the check for gcc_cv_libc_provides_ssp is not complete, as has > > already pointed out (with patches!) before, but is still not fixed on > > trunk. Let me revisit that: in configure.ac it is being checked for > > ``case "$target" in *-*-linux*)'' which should rather match ``*-*-linux* > > | *-*-*-gnu* | *-*-gnu*'' to catch all GNU/Linux, GNU/Hurd, GNU/k*BSD > > systems. (This is being patched in the Debian GCC package for some time > > already.) > > Even though the NATIVE_SYSTEM_HEADER_DIR issue is still being discussed, > in either way we'll need this patch installed. Any objections? > > 2008-10-10 Thomas Schwinge <tschwinge@gnu.org> > > * configure.ac (gcc_cv_libc_provides_ssp): Also consider GNU/kFreeBSD, > GNU/kNetBSD and GNU/Hurd systems. Here is a better variant. Paolo (you had already acked the previous version), but is this OK to install into trunk (see the additional Hurd-only change)? Index: configure.ac =================================================================== --- configure.ac (Revision 141837) +++ configure.ac (Arbeitskopie) @@ -3474,7 +3474,7 @@ gcc_cv_libc_provides_ssp, [gcc_cv_libc_provides_ssp=no case "$target" in - *-*-linux*) + *-*-linux* | *-*-kfreebsd*-gnu | *-*-knetbsd*-gnu) if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then if test "x$with_sysroot" = x; then glibc_header_dir="${exec_prefix}/${target_noncanonical}/sys-include" @@ -3510,6 +3510,12 @@ fi fi ;; + *-*-gnu*) + # Avoid complicated tests (see + # <http://gcc.gnu.org/ml/gcc/2008-10/msg00130.html>) and for now + # simply assert that glibc does provide this, which is true for all + # realistically usable configurations. + gcc_cv_libc_provides_ssp=yes;; *-*-darwin*) AC_CHECK_FUNC(__stack_chk_fail,[gcc_cv_libc_provides_ssp=yes], [echo "no __stack_chk_fail on this target"]) Regards, Thomas [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 191 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] build system: gcc_cv_libc_provides_ssp 2008-11-14 3:47 ` Thomas Schwinge @ 2008-11-14 7:30 ` Paolo Bonzini 2008-11-14 9:39 ` [COMMITTED] " Thomas Schwinge 0 siblings, 1 reply; 6+ messages in thread From: Paolo Bonzini @ 2008-11-14 7:30 UTC (permalink / raw) To: Thomas Schwinge; +Cc: jakub, gcc-patches, bug-hurd, debian-bsd > + *-*-gnu*) > + # Avoid complicated tests (see > + # <http://gcc.gnu.org/ml/gcc/2008-10/msg00130.html>) and for now > + # simply assert that glibc does provide this, which is true for all > + # realistically usable configurations. Write "Hurd configurations", otherwise ok. Paolo ^ permalink raw reply [flat|nested] 6+ messages in thread
* [COMMITTED] build system: gcc_cv_libc_provides_ssp 2008-11-14 7:30 ` Paolo Bonzini @ 2008-11-14 9:39 ` Thomas Schwinge 0 siblings, 0 replies; 6+ messages in thread From: Thomas Schwinge @ 2008-11-14 9:39 UTC (permalink / raw) To: Paolo Bonzini; +Cc: jakub, bug-hurd, gcc-patches, debian-bsd [-- Attachment #1: Type: text/plain, Size: 872 bytes --] Hello! On Fri, Nov 14, 2008 at 07:29:37AM +0100, Paolo Bonzini wrote: > > + *-*-gnu*) > > + # Avoid complicated tests (see > > + # <http://gcc.gnu.org/ml/gcc/2008-10/msg00130.html>) and for now > > + # simply assert that glibc does provide this, which is true for all > > + # realistically usable configurations. > > Write "Hurd configurations", otherwise ok. Thanks; installed as two separate changes: 2008-11-14 Thomas Schwinge <tschwinge@gnu.org> * configure.ac (gcc_cv_libc_provides_ssp): Also consider GNU/kFreeBSD, GNU/kNetBSD systems in the `*-*-linux*' case. * configure: Regenerate. 2008-11-14 Thomas Schwinge <tschwinge@gnu.org> * configure.ac (gcc_cv_libc_provides_ssp): Also consider GNU/Hurd systems, which are assumend to always provide SSP-support in glibc. * configure: Regenerate. Regards, Thomas [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 191 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-11-14 9:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20081008095357.GH7127@fencepost.gnu.org> 2008-10-10 10:09 ` [PATCH] build system: gcc_cv_libc_provides_ssp Thomas Schwinge 2008-10-10 14:43 ` Paolo Bonzini 2008-10-10 15:01 ` Paolo Bonzini 2008-11-14 3:47 ` Thomas Schwinge 2008-11-14 7:30 ` Paolo Bonzini 2008-11-14 9:39 ` [COMMITTED] " Thomas Schwinge
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).