From: Jakub Jelinek <jakub@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: "Manuel López-Ibáñez" <lopezibanez@gmail.com>,
"Gcc Patch List" <gcc-patches@gcc.gnu.org>,
"Mark Mitchell" <mark@codesourcery.com>
Subject: Re: PR c++/36921 [4.3/4.4 Regression] warning "comparison does not have mathematical meaning" is not correct for overloaded operators that do not return boolean
Date: Sat, 20 Dec 2008 12:43:00 -0000 [thread overview]
Message-ID: <20081220001432.GM17496@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <20081219234720.GL17496@tyan-ft48-01.lab.bos.redhat.com>
On Sat, Dec 20, 2008 at 12:47:20AM +0100, Jakub Jelinek wrote:
> On Fri, Dec 19, 2008 at 06:29:48PM -0500, Jason Merrill wrote:
> > Since, as you point out, we aren't actually missing any wanted warnings,
> > I don't mind putting this logic in warn_about_parentheses. But the test
> > should still check the types of the arguments rather than the whole
> > expression.
>
> You're right, that works too. I've so far just checked this testcase,
> will do full bootstrap/regtest soon.
While it works for C++, it doesn't for C, where the type of the comparison
argument is INTEGER_TYPE. I guess using INTEGRAL_TYPE_P instead should work
though.
Jakub
next prev parent reply other threads:[~2008-12-20 0:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 16:52 Manuel López-Ibáñez
2008-10-25 17:10 ` Jakub Jelinek
2008-11-04 22:15 ` Manuel López-Ibáñez
2008-12-03 17:49 ` Mark Mitchell
2008-12-19 23:32 ` Jason Merrill
2008-12-19 23:38 ` Jakub Jelinek
2008-12-19 23:50 ` Jason Merrill
2008-12-20 0:13 ` Mark Mitchell
2008-12-20 0:17 ` Jakub Jelinek
2008-12-20 12:43 ` Jakub Jelinek [this message]
2008-12-20 13:38 ` Jakub Jelinek
2008-12-20 22:33 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081220001432.GM17496@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=lopezibanez@gmail.com \
--cc=mark@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).