public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* PATCH: PR target/39935: Incorrect comments for %z modifier
@ 2009-04-28  0:33 H.J. Lu
  0 siblings, 0 replies; only message in thread
From: H.J. Lu @ 2009-04-28  0:33 UTC (permalink / raw)
  To: gcc-patches; +Cc: ubizjak

Comments on %z modifier in i386.c/i386.md are incorrect, which confuses
users.  This patch updates those comments for 4.3/4.4 branches.  For
trunk, we can add %Z modifier for register/memory operand on integer
instructions.  I will provide a different patch for trunk.  OK for
4.3/4.4?

Thanks.


H.J.
---
2009-04-27  H.J. Lu  <hongjiu.lu@intel.com>

	PR target/39935
	* config/i386/i386.c (print_operand): Update comments for 'z'.
	* config/i386/i386.md: Likewise.

Index: gcc/config/i386/i386.md
===================================================================
--- gcc/config/i386/i386.md	(revision 145983)
+++ gcc/config/i386/i386.md	(working copy)
@@ -27,8 +27,9 @@
 ;; See file "rtl.def" for documentation on define_insn, match_*, et. al.
 ;;
 ;; The special asm out single letter directives following a '%' are:
-;; 'z' mov%z1 would be movl, movw, or movb depending on the mode of
-;;     operands[1].
+;; 'z' print the appropriate instruction suffix for the size of the
+;;     current register/memory operand on x87 instructions and register
+;;     operand on integer instructions.
 ;; 'L' Print the opcode suffix for a 32-bit integer opcode.
 ;; 'W' Print the opcode suffix for a 16-bit integer opcode.
 ;; 'B' Print the opcode suffix for an 8-bit integer opcode.
Index: gcc/config/i386/i386.c
===================================================================
--- gcc/config/i386/i386.c	(revision 145983)
+++ gcc/config/i386/i386.c	(working copy)
@@ -10725,7 +10725,9 @@ get_some_local_dynamic_name (void)
    O -- if HAVE_AS_IX86_CMOV_SUN_SYNTAX, expand to "w.", "l." or "q.",
         otherwise nothing
    R -- print the prefix for register names.
-   z -- print the opcode suffix for the size of the current operand.
+   z -- print the appropriate instruction suffix for the size of the
+	current register/memory operand on x87 instructions and register
+	operand on integer instructions.
    * -- print a star (in certain assembler syntax)
    A -- print an absolute memory reference.
    w -- print the operand as if it's a "word" (HImode) even if it isn't.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-28  0:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-28  0:33 PATCH: PR target/39935: Incorrect comments for %z modifier H.J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).