public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: Kai Tietz <ktietz70@googlemail.com>, bug-libtool@gnu.org
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: RFA: libtool.m4
Date: Tue, 28 Apr 2009 18:51:00 -0000	[thread overview]
Message-ID: <20090428184541.GC13835@gmx.de> (raw)
In-Reply-To: <90baa01f0904280529x4e3eb21ds3d186849e5b3d187@mail.gmail.com>

[ adding bug-libtool; you can remove gcc-patches from followups ]

* Kai Tietz wrote on Tue, Apr 28, 2009 at 02:29:12PM CEST:
> >> In the libtool.m4 in function _LT_CHECK_MAGIC_METHOD the current check
> >> for mingw doesn't treat the x64 proper.
> >> It checks for 'file_magic file format pei*-i386(.*architecture:
> >> i386)?', what is right for 32-bit mingw, but for 64-bit version this
> >> string needs to be changed to something like 'file_magic file format
> >> pei*(.*architecture: i386)?'

> I did the libtool testsuite run for w64 target and found no serious
> issues (as I expected). But the underlying issue isn't tested in the
> suite at all my initial post is pointing on. The problem is that the
> pattern used (and so also in libtool itself) for detection if a dll
> (windows shared object) is generated is wrong.

So, can you devise a short example, or ideally even a testsuite addition
to git Libtool that exposes this issue?  Alternatively, describe the
situation in which you encountered it.

> in aclocal.m4 there is the line
> 'lt_cv_deplibs_check_method='file_magic file format
> pei*-i386(.*architecture: i386)?'
> which doesn't fit for 64-bit dlls.
> lt_cv_deplibs_check_method='file_magic file format
> pei*-(i386|x86_64)(.*architecture: i386)?'

> If you are interest in the testrun files, please tell me. I can sent
> them to you.

If there are no testsuite failures, then no, I don't need them.  Thanks.

Cheers,
Ralf

      reply	other threads:[~2009-04-28 18:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-25 20:10 Kai Tietz
2009-04-27 19:49 ` Ralf Wildenhues
2009-04-28 12:51   ` Kai Tietz
2009-04-28 18:51     ` Ralf Wildenhues [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090428184541.GC13835@gmx.de \
    --to=ralf.wildenhues@gmx.de \
    --cc=bug-libtool@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ktietz70@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).