From: Eric Botcazou <ebotcazou@adacore.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Scalar evolution and hidden casts
Date: Tue, 19 May 2009 10:39:00 -0000 [thread overview]
Message-ID: <200905191244.32100.ebotcazou@adacore.com> (raw)
In-Reply-To: <84fc9c000905190247k352c3c74m59028d0d9191dba2@mail.gmail.com>
> Beware! COMPLEX_EXPR is tcc_binary and your changes will
> cause the wrong type to be used!
You're right, but follow_ssa_edge_binary only handles POINTER_PLUS_EXPR,
PLUS_EXPR and MINUS_EXPR so this doesn't really matter. I guess I should
specifically test for the 3 codes, like in follow_ssa_edge_expr.
> I suppose you specifically hit the POINTER_PLUS_EXPR case?
> Maybe just special-case that like in gimple_expr_type and use
> that in follow_ssa_edge_in_rhs.
No, it's the PLUS_EXPR case.
--
Eric Botcazou
next prev parent reply other threads:[~2009-05-19 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 9:13 Eric Botcazou
2009-05-19 9:47 ` Richard Guenther
2009-05-19 10:39 ` Eric Botcazou [this message]
2009-05-19 10:48 ` Richard Guenther
2009-05-19 11:33 ` Eric Botcazou
2009-05-19 11:50 ` Richard Guenther
2009-10-11 19:47 ` H.J. Lu
2009-12-27 15:49 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905191244.32100.ebotcazou@adacore.com \
--to=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).