From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-244705-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4838 invoked by alias); 10 Jul 2009 07:36:25 -0000
Received: (qmail 4819 invoked by uid 22791); 10 Jul 2009 07:36:24 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jul 2009 07:36:17 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n6A7aF5R021401; 	Fri, 10 Jul 2009 03:36:15 -0400
Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n6A7aEc5024664; 	Fri, 10 Jul 2009 03:36:14 -0400
Received: (from jakub@localhost) 	by tyan-ft48-01.lab.bos.redhat.com (8.14.2/8.14.2/Submit) id n6A7aEHZ012219; 	Fri, 10 Jul 2009 09:36:14 +0200
Date: Fri, 10 Jul 2009 07:56:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Matthias Klose <doko@ubuntu.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,         Paolo Carlini <paolo.carlini@oracle.com>,         GCJ-patches <java-patches@gcc.gnu.org>
Subject: Re: [patch] PR40134, use a linker script on arm-linux to link with 	-lgcc_s  -lgcc
Message-ID: <20090710073614.GW4462@tyan-ft48-01.lab.bos.redhat.com>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <4A530F5C.4040500@ubuntu.com> <20090707091425.GB4462@tyan-ft48-01.lab.bos.redhat.com> <4A56D949.4010900@ubuntu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A56D949.4010900@ubuntu.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2009-07/txt/msg00556.txt.bz2

On Fri, Jul 10, 2009 at 08:01:45AM +0200, Matthias Klose wrote:
> H.J. mentioned not to bother with the dfp library for now. Is the current patch
> good enough for mainline?
> 
>   Matthias
> 

> Index: gcc.c
> ===================================================================
> --- a/src/gcc/gcc.c	(revision 149315)
> +++ b/src/gcc/gcc.c	(working copy)
> @@ -1686,13 +1686,21 @@
>  		"}"
>  #ifdef LINK_EH_SPEC
>  		"%{shared:"
> +#ifdef ENABLE_SHARED_LIBGCC

What are these #ifdefs good for?

Isn't the whole init_gcc_specs routine wrapped in
#if defined(ENABLE_SHARED_LIBGCC) && !defined(REAL_LIBGCC_SPEC)
?

> +		"%{shared-libgcc:", shared_name, " ", static_name, "}"
> +#else
>  		"%{shared-libgcc:", shared_name, "}"
> +#endif
>  		"%{!shared-libgcc:", static_name, "}"
>  		"}"
>  #else
> +#ifdef ENABLE_SHARED_LIBGCC
> +		"%{shared:", shared_name, " ", static_name, "}"
> +#else
>  		"%{shared:", shared_name, "}"
>  #endif
>  #endif
> +#endif
>  		"}}", NULL);
>  
>    obstack_grow (obstack, buf, strlen (buf));


	Jakub