[patch, testsuite] set GCC_EXEC_PREFIX *before* building testglue.c

[patch, testsuite] set GCC_EXEC_PREFIX *before* building testglue.c

[DJ Delorie]

I suspect this may be obvious, but that doesn't mean there aren't
hidden side-effects.  When you test in-tree with a cross target
requiring a status wrapper, the status wrapper can't be built because
GCC_EXEC_PREFIX hasn't been set yet.  This sets it if needed.  Ok to
apply?

	* lib/wrapper.exp (${tool}_maybe_build_wrapper): Set up
	GCC_EXEC_PREFIX before building the wrapper.
 
 2009-08-13  Janus Weil  <janus@gcc.gnu.org>
Index: lib/wrapper.exp
===================================================================
--- lib/wrapper.exp	(revision 150735)
+++ lib/wrapper.exp	(working copy)
@@ -13,23 +13,26 @@
 # You should have received a copy of the GNU General Public License
 # along with GCC; see the file COPYING3.  If not see
 # <http://www.gnu.org/licenses/>.
 
 # This file contains GCC-specifics for status wrappers for test programs.
 
+load_lib target-libpath.exp
+
 # ${tool}_maybe_build_wrapper -- Build wrapper object if the target
 # needs it.  FILENAME is the path to the wrapper file.  If there are
 # additional arguments, they are command-line options to provide to
 # the compiler when compiling FILENAME.
 
 proc ${tool}_maybe_build_wrapper { filename args } {
     global gluefile wrap_flags
 
     if { [target_info needs_status_wrapper] != "" \
  	 && [target_info needs_status_wrapper] != "0" \
 	 && ![info exists gluefile] } {
+	set_ld_library_path_env_vars
 	set saved_wrap_compile_flags [target_info wrap_compile_flags]
 	set flags [join $args " "]
 	# The wrapper code may contain code that gcc objects on.  This
 	# became true for dejagnu-1.4.4.  The set of warnings and code
 	# that gcc objects on may change, so just make sure -w is always
 	# passed to turn off all warnings.

Re: [patch, testsuite] set GCC_EXEC_PREFIX *before* building testglue.c

[Janis Johnson]

On Fri, 2009-08-14 at 14:57 -0400, DJ Delorie wrote:
> I suspect this may be obvious, but that doesn't mean there aren't
> hidden side-effects.  When you test in-tree with a cross target
> requiring a status wrapper, the status wrapper can't be built because
> GCC_EXEC_PREFIX hasn't been set yet.  This sets it if needed.  Ok to
> apply?
> 
> 	* lib/wrapper.exp (${tool}_maybe_build_wrapper): Set up
> 	GCC_EXEC_PREFIX before building the wrapper.

OK.

Janis

Re: [patch, testsuite] set GCC_EXEC_PREFIX *before* building testglue.c

[DJ Delorie]

Thanks, committed.

Re: [patch, testsuite] set GCC_EXEC_PREFIX *before* building testglue.c

[H.J. Lu]

On Tue, Aug 18, 2009 at 11:37 AM, DJ Delorie<dj@redhat.com> wrote:
>
> Thanks, committed.
>

It breaks library tests:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41114

-- 
H.J.

Re: [patch, testsuite] set GCC_EXEC_PREFIX *before* building testglue.c

[DJ Delorie]

> It breaks library tests:

Please be more specific.  Which library tests?  Which tools?  The test
results you point to don't include the messages you quoted.

Re: [patch, testsuite] set GCC_EXEC_PREFIX *before* building testglue.c

[H.J. Lu]

On Tue, Aug 18, 2009 at 5:59 PM, DJ Delorie<dj@redhat.com> wrote:
>
>> It breaks library tests:
>
> Please be more specific.  Which library tests?  Which tools?  The test
> results you point to don't include the messages you quoted.
>

In

http://gcc.gnu.org/ml/gcc-testresults/2009-08/msg01955.html

there are no libstdc++ test results at all and libffi tests never run.


-- 
H.J.

Re: [patch, testsuite] set GCC_EXEC_PREFIX *before* building testglue.c

[DJ Delorie]

> http://gcc.gnu.org/ml/gcc-testresults/2009-08/msg01955.html
> 
> there are no libstdc++ test results at all and libffi tests never run.

Ah, found it.  Everything else that uses wrapper.exp gives a full
path, but loads target-libpath.exp manually.  So I did the same for
gcc.  I'm checking in this change, please let me know if your test
results go back to normal.

	* lib/wrapper.exp: Move load of target-libpath.exp from here...
	* lib/gcc-defs.exp: ... to here.
 
Index: lib/wrapper.exp
===================================================================
--- lib/wrapper.exp	(revision 150928)
+++ lib/wrapper.exp	(working copy)
@@ -13,14 +13,12 @@
 # You should have received a copy of the GNU General Public License
 # along with GCC; see the file COPYING3.  If not see
 # <http://www.gnu.org/licenses/>.
 
 # This file contains GCC-specifics for status wrappers for test programs.
 
-load_lib target-libpath.exp
-
 # ${tool}_maybe_build_wrapper -- Build wrapper object if the target
 # needs it.  FILENAME is the path to the wrapper file.  If there are
 # additional arguments, they are command-line options to provide to
 # the compiler when compiling FILENAME.
 
 proc ${tool}_maybe_build_wrapper { filename args } {
Index: lib/gcc-defs.exp
===================================================================
--- lib/gcc-defs.exp	(revision 150928)
+++ lib/gcc-defs.exp	(working copy)
@@ -11,12 +11,14 @@
 # GNU General Public License for more details.
 # 
 # You should have received a copy of the GNU General Public License
 # along with GCC; see the file COPYING3.  If not see
 # <http://www.gnu.org/licenses/>.
 
+load_lib target-libpath.exp
+
 load_lib wrapper.exp
 
 #
 # ${tool}_check_compile -- Reports and returns pass/fail for a compilation
 #