From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24556 invoked by alias); 6 Sep 2009 09:57:09 -0000 Received: (qmail 24547 invoked by uid 22791); 6 Sep 2009 09:57:08 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.gmx.net (HELO mail.gmx.net) (213.165.64.20) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sun, 06 Sep 2009 09:57:02 +0000 Received: (qmail invoked by alias); 06 Sep 2009 09:56:59 -0000 Received: from xdsl-87-78-135-11.netcologne.de (EHLO localhost.localdomain) [87.78.135.11] by mail.gmx.net (mp064) with SMTP; 06 Sep 2009 11:56:59 +0200 Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1MkEUP-0008NT-7K; Sun, 06 Sep 2009 11:56:53 +0200 Date: Sun, 06 Sep 2009 09:57:00 -0000 From: Ralf Wildenhues To: Richard Guenther Cc: Kai Tietz , GCC Patches , Richard Henderson Subject: Re: [patch]: Add check for stdint header Message-ID: <20090906095652.GA32174@gmx.de> Mail-Followup-To: Ralf Wildenhues , Richard Guenther , Kai Tietz , GCC Patches , Richard Henderson References: <90baa01f0909021518w469a8991ga54bacf8f7df68f9@mail.gmail.com> <84fc9c000909030355r6843e245j5f5290b021d4ec0e@mail.gmail.com> <90baa01f0909030405q77ba38b0ibb0eebc8c3b560a4@mail.gmail.com> <84fc9c000909030409u2fc11f7fs5c9d4fe60dd7c6a1@mail.gmail.com> <90baa01f0909040049k36a03c4s5ae3a65d3d9153d0@mail.gmail.com> <84fc9c000909040257r44566fc7ra3ff886701d57edd@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84fc9c000909040257r44566fc7ra3ff886701d57edd@mail.gmail.com> User-Agent: Mutt/1.5.20 (2009-08-09) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-09/txt/msg00416.txt.bz2 * Richard Guenther wrote on Fri, Sep 04, 2009 at 11:57:23AM CEST: > I suppose the explicit check for stdint.h is not necessary and you need to > cover for the case where inttypes.h provides the required definition. See > the autoconf manual which says > > -- Macro: AC_TYPE_INTPTR_T > If `stdint.h' or `inttypes.h' defines the type `intptr_t', define > `HAVE_INTPTR_T'. Otherwise, define `intptr_t' to a signed integer > type wide enough to hold a pointer, if such a type exists. > > I don't know what the canonical header inclusion case to use would be > though. Maybe Ralf knows. FWIW (since I've been asked by name here) I can't see obvious issues with the patches in this thread, but also, the GCC build system maintainers know much better what is needed for GCC here than I do. Using AC_TYPE_INTPTR_T outside of GCC, you'd include both inttypes.h and stdint.h, if they are available; that's what the test does, too. Cheers, Ralf