public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: rth@redhat.com (Richard Henderson)
Cc: richard.guenther@gmail.com (Richard Guenther), gcc-patches@gcc.gnu.org
Subject: Re: [PATCH PING 2/5] Named address spaces: support multiple pointer      modes
Date: Tue, 22 Sep 2009 22:51:00 -0000	[thread overview]
Message-ID: <200909222250.n8MMo1Lp009357@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <4AB93248.103@redhat.com> from "Richard Henderson" at Sep 22, 2009 01:23:36 PM

Richard Henderson wrote:
> On 09/21/2009 06:41 AM, Ulrich Weigand wrote:
> > --- gcc/alias.c	(working copy)
> > *************** along with GCC; see the file COPYING3.
> > *** 49,55 ****
> >    #include "tree-ssa-alias.h"
> >    #include "pointer-set.h"
> >    #include "tree-flow.h"
> > ! #include "targhooks.h"
> >
> >    /* The aliasing API provided here solves related but different problems:
> >
> > --- 49,55 ----
> >    #include "tree-ssa-alias.h"
> >    #include "pointer-set.h"
> >    #include "tree-flow.h"
> > ! #include "target-def.h"
> 
> 
> If you have to make this change, you've placed the macro
> in the wrong place.

Note that this patch applies to the branch; mainline currently
contains neither of the includes.  So this basically only changes
the resulting mainline patch into adding #include "target-def.h"
instead of adding #include "targhooks.h" ...

It seemed to me that of the two, target-def.h was a more natural
place for the new macro.  If you have a better suggestion where
to place it, I'll be happy to do so ...

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

  reply	other threads:[~2009-09-22 22:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16 16:50 Ulrich Weigand
2009-09-20  1:52 ` Richard Guenther
2009-09-21 13:52   ` Ulrich Weigand
2009-09-21 15:31     ` Richard Guenther
2009-09-21 15:35       ` Ulrich Weigand
2009-09-22 20:26     ` Richard Henderson
2009-09-22 22:51       ` Ulrich Weigand [this message]
2009-09-22 23:21         ` Joseph S. Myers
2009-09-23  0:11         ` Richard Henderson
2009-09-23  1:17           ` Ulrich Weigand
2009-09-23 15:26             ` Richard Henderson
2009-09-24 16:08               ` Ulrich Weigand
2009-09-24 16:50                 ` Richard Henderson
2009-09-24 18:26                   ` Ulrich Weigand
2009-09-24 18:43                     ` Richard Henderson
2009-09-24 20:40                       ` Ulrich Weigand
2009-11-14 20:53 Dmitry Gorbachev
2009-11-16 20:06 ` Ulrich Weigand
2009-11-17  6:13   ` Dmitry Gorbachev
2009-11-17 16:18     ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909222250.n8MMo1Lp009357@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).