From: Jakub Jelinek <jakub@redhat.com>
To: Michael Meissner <meissner@linux.vnet.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, committed] PR target/23983, fix builtin attributes on powerpc
Date: Mon, 19 Oct 2009 22:24:00 -0000 [thread overview]
Message-ID: <20091019220616.GC14664@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <20091015205648.GA32037@hungry-tiger.westford.ibm.com>
On Thu, Oct 15, 2009 at 04:56:48PM -0400, Michael Meissner wrote:
> I just committed the following patch. When I was doing a backport of the vsx
> changes to 4.3, I noticed that I had not updated the copyright years for two of
> the files I checked in July, so I updated these as well.
This sets the wrong bit for RS6000_BTC_CONST - __attribute__((const))
functions have TREE_READONLY set on the decl, instead of TREE_CONSTANT, and
that's e.g. what flags_from_decl_or_type is testing.
Untested so far...
2009-10-19 Jakub Jelinek <jakub@redhat.com>
* config/rs6000/rs6000.c (def_builtin): Set TREE_READONLY instead
of TREE_CONSTANT.
--- gcc/config/rs6000/rs6000.c 2009-10-15 23:23:25.000000000 +0200
+++ gcc/config/rs6000/rs6000.c 2009-10-19 23:51:26.000000000 +0200
@@ -8530,7 +8530,7 @@ def_builtin (int mask, const char *name,
/* const function, function only depends on the inputs. */
case RS6000_BTC_CONST:
- TREE_CONSTANT (t) = 1;
+ TREE_READONLY (t) = 1;
TREE_NOTHROW (t) = 1;
break;
@@ -8554,7 +8554,7 @@ def_builtin (int mask, const char *name,
DECL_IS_NOVOPS (t) = 1;
}
else
- TREE_CONSTANT (t) = 1;
+ TREE_READONLY (t) = 1;
break;
}
}
Jakub
next prev parent reply other threads:[~2009-10-19 22:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 18:58 [PATCH] Fix " Michael Meissner
2009-10-01 19:01 ` Andrew Pinski
2009-10-01 19:14 ` Michael Meissner
2009-10-13 13:36 ` David Edelsohn
2009-10-13 20:40 ` Michael Meissner
2009-10-14 0:02 ` David Edelsohn
2009-10-14 9:58 ` Richard Guenther
2009-10-14 15:21 ` Michael Meissner
2009-10-14 16:19 ` Richard Guenther
2009-10-14 20:08 ` David Edelsohn
2009-10-14 22:21 ` Michael Meissner
2009-10-15 20:59 ` [PATCH, committed] PR target/23983, fix " Michael Meissner
2009-10-19 22:24 ` Jakub Jelinek [this message]
2009-10-20 16:29 ` Jakub Jelinek
2009-10-20 17:56 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019220616.GC14664@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).