From: Kaz Kojima <kkojima@rr.iij4u.or.jp>
To: joseph@codesourcery.com
Cc: gcc-patches@gcc.gnu.org, aoliva@redhat.com
Subject: Re: Fix SH PIE TLS ICE
Date: Wed, 21 Oct 2009 13:03:00 -0000 [thread overview]
Message-ID: <20091021.220022.196146971.kkojima@rr.iij4u.or.jp> (raw)
In-Reply-To: <Pine.LNX.4.64.0910211223160.17590@digraph.polyomino.org.uk>
"Joseph S. Myers" <joseph@codesourcery.com> wrote:
> This patch fixes an ICE that appears when compiling code using TLS
> variables for SH with -fpie or -fPIE. This combination causes
> UNSPEC_TPOFF - the Local Exec model - to be used in
> position-independent code. @TPOFF should be fine in a PIE; the value
> is resolved at link time and does not depend on the location of the
> executable, while if code for a shared library is being built (-fpic
> or -fPIC) then UNSPEC_TPOFF will never be generated anyway because the
> Local Exec TLS model will not be used. So I think
> nonpic_symbol_mentioned_p should allow this case.
>
> Tested with no regressions with cross to sh-linux-gnu. OK to commit?
OK. Thanks for the patch!
Regards,
kaz
prev parent reply other threads:[~2009-10-21 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 12:34 Joseph S. Myers
2009-10-21 13:03 ` Kaz Kojima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091021.220022.196146971.kkojima@rr.iij4u.or.jp \
--to=kkojima@rr.iij4u.or.jp \
--cc=aoliva@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).