From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>,
Bernd Schmidt <bernds_cb1@t-online.de>,
gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com
Subject: Re: Use simplify_replace_rtx rather than wrap_constant
Date: Wed, 21 Oct 2009 20:45:00 -0000 [thread overview]
Message-ID: <20091021203634.GN14664@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <87iqe81p6l.fsf@firetop.home>
On Wed, Oct 21, 2009 at 09:12:50PM +0100, Richard Sandiford wrote:
> * simplify-rtx.c (simplify_replace_fn_rtx): Handle UNSPECs
> and UNSPEC_VOLATILEs too.
I think we shouldn't special case UNSPEC*. There might be something else
too (e.g. CONCAT, CONCATN, CONST, PRE_DEC, ...).
If this routine is to be used, it IMHO should just in the case that isn't
already handled go through the format string and for any 'e's there
simplify_replace_fn_rtx the operand, if it returns something different
shallow_copy_rtx x unless already done. Similarly for 'E'.
In your handling of UNSPEC, I don't understand the copy_rtx, I think
currently simplify_replace_rtx doesn't guarantee 100% unsharing of
everything, so I think you should unshare only the operands where recursive
call actually changed something.
Jakub
next prev parent reply other threads:[~2009-10-21 20:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 16:15 Richard Sandiford
2009-09-26 21:11 ` Richard Sandiford
2010-01-09 20:37 ` H.J. Lu
2009-09-30 9:38 ` Alexandre Oliva
2009-09-30 20:23 ` Richard Sandiford
2009-09-30 12:45 ` Bernd Schmidt
2009-09-30 20:12 ` Richard Sandiford
2009-10-01 11:54 ` Bernd Schmidt
2009-10-01 21:05 ` Richard Sandiford
2009-10-05 14:23 ` Bernd Schmidt
2009-10-11 19:36 ` Richard Sandiford
2009-10-12 18:23 ` Richard Sandiford
2009-10-19 23:59 ` Bernd Schmidt
2009-10-21 15:53 ` Jakub Jelinek
2009-10-21 16:53 ` Jakub Jelinek
2009-10-21 17:13 ` [PATCH] " Jakub Jelinek
2009-10-21 20:13 ` Richard Sandiford
2009-10-21 22:17 ` Richard Sandiford
2009-10-21 17:26 ` Ulrich Weigand
2009-10-21 20:36 ` Richard Sandiford
2009-10-21 20:45 ` Jakub Jelinek [this message]
2009-10-21 21:25 ` Richard Sandiford
2009-10-21 22:01 ` Richard Sandiford
2009-10-22 17:17 ` Ulrich Weigand
2009-10-01 13:54 ` Eric Botcazou
2009-09-30 13:42 ` Paolo Bonzini
2009-09-30 13:49 ` Paolo Bonzini
2009-09-30 20:17 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091021203634.GN14664@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=bernds_cb1@t-online.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdsandiford@googlemail.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).