From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7929 invoked by alias); 30 Oct 2009 14:40:27 -0000 Received: (qmail 7903 invoked by uid 22791); 30 Oct 2009 14:40:26 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Oct 2009 14:40:20 +0000 Received: from relay2.suse.de (mail2.suse.de [195.135.221.8]) by mx2.suse.de (Postfix) with ESMTP id F331979727; Fri, 30 Oct 2009 15:40:17 +0100 (CET) Date: Fri, 30 Oct 2009 14:49:00 -0000 From: Martin Jambor To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org Subject: Re: [Ada] constrained discriminated records and SRA Message-ID: <20091030144015.GA26481@virgil.suse.cz> Mail-Followup-To: Eric Botcazou , gcc-patches@gcc.gnu.org References: <200909291257.28654.ebotcazou@adacore.com> <200910160858.13450.ebotcazou@adacore.com> <20091022104249.GA11795@virgil.suse.cz> <200910221340.23382.ebotcazou@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <200910221340.23382.ebotcazou@adacore.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg01799.txt.bz2 Hi, On Thu, Oct 22, 2009 at 01:40:22PM +0200, Eric Botcazou wrote: > > So my suggestion would be to remove the whole comment, or replace it > > with something saying that if looking up stuff in records is deemed > > too slow in future, we should be able to simplify it now. > > FWIW fine with me either way. I have committed the following change as revision 153751. Thanks, Martin 2009-10-30 Martin Jambor * tree-sra.c (build_ref_for_offset_1): Remove a comment. Index: mine/gcc/tree-sra.c =================================================================== --- mine.orig/gcc/tree-sra.c +++ mine/gcc/tree-sra.c @@ -1231,8 +1231,6 @@ build_ref_for_offset_1 (tree *res, tree case UNION_TYPE: case QUAL_UNION_TYPE: case RECORD_TYPE: - /* ??? Some records used to be half-unions in Ada so the code treats - the 3 container types the same. This has been fixed in Ada. */ for (fld = TYPE_FIELDS (type); fld; fld = TREE_CHAIN (fld)) { HOST_WIDE_INT pos, size; > > -- > Eric Botcazou