Ping: [PATCH] Add DWARF constant for Borland fastcall calling convention

Ping: [PATCH] Add DWARF constant for Borland fastcall calling convention

[Jonas Maebe]

Hello,

This is basically a ping for http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00301.html

I've however added a comment describing this calling convention. This  
patch is all but accepted for gdb, but since gdb imports dwarf2.h from  
gcc, it should really be applied here too.

I don't have a copyright assignment on file yet for gcc (I've  
requested one), but I hope this can be checked in under the "tiny  
change" rule.

Thanks,


Jonas

--- gcc.org/dwarf2.h	2009-10-02 16:25:22.000000000 +0200
+++ gcc/dwarf2.h	2009-10-02 16:26:48.000000000 +0200
@@ -606,7 +606,14 @@
      DW_CC_normal = 0x1,
      DW_CC_program = 0x2,
      DW_CC_nocall = 0x3,
-    DW_CC_GNU_renesas_sh = 0x40
+    DW_CC_GNU_renesas_sh = 0x40,
+    /* Borland fastcall: register parameters are passed from left to  
right,
+       then stack parameters also from left to right.  The first three
+       unstructured parameters <= 32 bits are passed in %eax, %edx  
and %ecx.
+       The others are passed on the stack.  Furthermore, in case of a  
struct
+       return by reference, the address of this struct is passed as  
the first
+       (register) parameter.  */
+    DW_CC_GNU_borland_fastcall_i386 = 0x41
    };

  #define DW_CC_lo_user 0x40

Fwd: Ping: [PATCH] Add DWARF constant for Borland fastcall calling convention

[Jonas Maebe]

Ping.


From: Jonas Maebe <jonas.maebe@elis.ugent.be>
Date: Fri 2 Oct 2009 16:30:19 GMT+02:00
To: gcc-patches@gcc.gnu.org
Subject: Ping: [PATCH] Add DWARF constant for Borland fastcall calling  
convention

Hello,

This is basically a ping for http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00301.html

I've however added a comment describing this calling convention. This  
patch is all but accepted for gdb, but since gdb imports dwarf2.h from  
gcc, it should really be applied here too.

I don't have a copyright assignment on file yet for gcc (I've  
requested one), but I hope this can be checked in under the "tiny  
change" rule.

Thanks,


Jonas

--- gcc.org/dwarf2.h	2009-10-02 16:25:22.000000000 +0200
+++ gcc/dwarf2.h	2009-10-02 16:26:48.000000000 +0200
@@ -606,7 +606,14 @@
     DW_CC_normal = 0x1,
     DW_CC_program = 0x2,
     DW_CC_nocall = 0x3,
-    DW_CC_GNU_renesas_sh = 0x40
+    DW_CC_GNU_renesas_sh = 0x40,
+    /* Borland fastcall: register parameters are passed from left to  
right,
+       then stack parameters also from left to right.  The first three
+       unstructured parameters <= 32 bits are passed in %eax, %edx  
and %ecx.
+       The others are passed on the stack.  Furthermore, in case of a  
struct
+       return by reference, the address of this struct is passed as  
the first
+       (register) parameter.  */
+    DW_CC_GNU_borland_fastcall_i386 = 0x41
   };

#define DW_CC_lo_user 0x40

Fwd: Ping: [PATCH] Add DWARF constant for Borland fastcall calling convention

[Jonas Maebe]

Ping. Additionally, I now also have a copyright assignment on file for  
GCC.


Begin forwarded message:

From: Jonas Maebe <jonas.maebe@elis.ugent.be>
Date: Mon 19 Oct 2009 11:02:23 GMT+02:00
To: gcc-patches@gcc.gnu.org
Subject: Fwd: Ping: [PATCH] Add DWARF constant for Borland fastcall  
calling convention

Ping.


From: Jonas Maebe <jonas.maebe@elis.ugent.be>
Date: Fri 2 Oct 2009 16:30:19 GMT+02:00
To: gcc-patches@gcc.gnu.org
Subject: Ping: [PATCH] Add DWARF constant for Borland fastcall calling  
convention

Hello,

This is basically a ping for http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00301.html

I've however added a comment describing this calling convention. This  
patch is all but accepted for gdb, but since gdb imports dwarf2.h from  
gcc, it should really be applied here too.

[ no longer true, see above -- I don't have a copyright assignment on  
file yet for gcc (I've requested one), but I hope this can be checked  
in under the "tiny change" rule. ]

Thanks,


Jonas

--- gcc.org/dwarf2.h	2009-10-02 16:25:22.000000000 +0200
+++ gcc/dwarf2.h	2009-10-02 16:26:48.000000000 +0200
@@ -606,7 +606,14 @@
    DW_CC_normal = 0x1,
    DW_CC_program = 0x2,
    DW_CC_nocall = 0x3,
-    DW_CC_GNU_renesas_sh = 0x40
+    DW_CC_GNU_renesas_sh = 0x40,
+    /* Borland fastcall: register parameters are passed from left to  
right,
+       then stack parameters also from left to right.  The first three
+       unstructured parameters <= 32 bits are passed in %eax, %edx  
and %ecx.
+       The others are passed on the stack.  Furthermore, in case of a  
struct
+       return by reference, the address of this struct is passed as  
the first
+       (register) parameter.  */
+    DW_CC_GNU_borland_fastcall_i386 = 0x41
  };

#define DW_CC_lo_user 0x40

Re: Fwd: Ping: [PATCH] Add DWARF constant for Borland fastcall calling convention

[Joel Brobecker]

Hello GCC Maintainers,

I would like to bring my support to Jonas' request to add a new calling
convention to the DWARF2 spec dwarf2.h.  This is a necessary change
before we can use it in GDB in order to allow GDB to make calls to
certain functions compiled by the Borland compiler.  Could someone
have a look a the change for him, please?

Thank you!

On Fri, Oct 30, 2009 at 11:07:49AM +0100, Jonas Maebe wrote:
> Ping. Additionally, I now also have a copyright assignment on file for  
> GCC.
>
>
> Begin forwarded message:
>
> From: Jonas Maebe <jonas.maebe@elis.ugent.be>
> Date: Mon 19 Oct 2009 11:02:23 GMT+02:00
> To: gcc-patches@gcc.gnu.org
> Subject: Fwd: Ping: [PATCH] Add DWARF constant for Borland fastcall  
> calling convention
>
> Ping.
>
>
> From: Jonas Maebe <jonas.maebe@elis.ugent.be>
> Date: Fri 2 Oct 2009 16:30:19 GMT+02:00
> To: gcc-patches@gcc.gnu.org
> Subject: Ping: [PATCH] Add DWARF constant for Borland fastcall calling  
> convention
>
> Hello,
>
> This is basically a ping for http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00301.html
>
> I've however added a comment describing this calling convention. This  
> patch is all but accepted for gdb, but since gdb imports dwarf2.h from  
> gcc, it should really be applied here too.
>
> [ no longer true, see above -- I don't have a copyright assignment on  
> file yet for gcc (I've requested one), but I hope this can be checked in 
> under the "tiny change" rule. ]
>
> Thanks,
>
>
> Jonas
>
> --- gcc.org/dwarf2.h	2009-10-02 16:25:22.000000000 +0200
> +++ gcc/dwarf2.h	2009-10-02 16:26:48.000000000 +0200
> @@ -606,7 +606,14 @@
>    DW_CC_normal = 0x1,
>    DW_CC_program = 0x2,
>    DW_CC_nocall = 0x3,
> -    DW_CC_GNU_renesas_sh = 0x40
> +    DW_CC_GNU_renesas_sh = 0x40,
> +    /* Borland fastcall: register parameters are passed from left to  
> right,
> +       then stack parameters also from left to right.  The first three
> +       unstructured parameters <= 32 bits are passed in %eax, %edx and 
> %ecx.
> +       The others are passed on the stack.  Furthermore, in case of a  
> struct
> +       return by reference, the address of this struct is passed as the 
> first
> +       (register) parameter.  */
> +    DW_CC_GNU_borland_fastcall_i386 = 0x41
>  };
>
> #define DW_CC_lo_user 0x40
>
>

-- 
Joel

Re: Fwd: Ping: [PATCH] Add DWARF constant for Borland fastcall calling convention

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> Hello GCC Maintainers,
Joel> I would like to bring my support to Jonas' request to add a new calling
Joel> convention to the DWARF2 spec dwarf2.h.  This is a necessary change
Joel> before we can use it in GDB in order to allow GDB to make calls to
Joel> certain functions compiled by the Borland compiler.  Could someone
Joel> have a look a the change for him, please?

FYI, Ian said on irc that this patch is approved with a ChangeLog entry.
Joel, I assume you will be committing it?  Otherwise, let me know and I
will take care of it.

thanks,
Tom

Re: Fwd: Ping: [PATCH] Add DWARF constant for Borland fastcall calling convention

[Joel Brobecker]

> FYI, Ian said on irc that this patch is approved with a ChangeLog entry.
> Joel, I assume you will be committing it?  Otherwise, let me know and I
> will take care of it.

Thanks for doing that. The patch has now been checked in both GCC and
GDB.  I verified before committing that GDB still builds on x86_64-linux.

-- 
Joel