[PATCH,TESTSUITE]Clean up for AVR and other small targets]

[PATCH,TESTSUITE]Clean up for AVR and other small targets]

[Andrew Hutchinson]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]


The following patch cleans up tests for avr and other small integer targets.

2009-11-21  Andy Hutchinson <hutchinsonandy@gcc.gnu.org>

    * gcc.dg/pr36998.c: Frame pointer required for avr target.
    * gcc.dg/debug/pr41264-1.c: Use long if int size is 16bit or smaller.
    * gcc.dg/pr39226.c: Use smaller bitfield if int size is 16bit.
    * gcc.dg/pr41340.c: Test requires long pointer target.
    * gcc.dg/profile-generate-3.c: Test requires profiling support.

Ok for 4.5 head?





[-- Attachment #2: avrclean1.patch --]
[-- Type: text/plain, Size: 2299 bytes --]

Index: debug/pr41264-1.c
===================================================================
--- debug/pr41264-1.c	(revision 154399)
+++ debug/pr41264-1.c	(working copy)
@@ -1,6 +1,10 @@
 /* { dg-do compile } */
 
+#if (__SIZEOF_INT__ <= 2)	
+typedef unsigned long hashval_t;
+#else
 typedef unsigned int hashval_t;
+#endif
 static hashval_t __attribute__((always_inline))
 iterative_hash_host_wide_int (long val, hashval_t val2)
 {
Index: pr36998.c
===================================================================
--- pr36998.c	(revision 154399)
+++ pr36998.c	(working copy)
@@ -2,6 +2,7 @@
 /* { dg-do compile } */
 /* { dg-options "-Os -fasynchronous-unwind-tables" } */
 /* { dg-options "-Os -mpreferred-stack-boundary=2 -fasynchronous-unwind-tables" { target { { i?86-*-* x86_64-*-* } && ilp32 } } } */
+/* { dg-options "-fno-omit-frame-pointer" { target { avr-*-* } } } */
 
 void foo (const char *, ...) __attribute__ ((noreturn));
 int bar (const char *, ...);
Index: pr39226.c
===================================================================
--- pr39226.c	(revision 154399)
+++ pr39226.c	(working copy)
@@ -3,12 +3,21 @@
 /* { dg-options "-O2" } */
 /* { dg-options "-O2 -mtune=cell -mminimal-toc" { target { powerpc*-*-* && lp64 } } } */
 
+#if (__SIZEOF_INT__ == 2)	
 struct A
 {
   char *a;
   unsigned int b : 1;
+  unsigned int c : 15;
+};
+#else
+struct A
+{
+  char *a;
+  unsigned int b : 1;
   unsigned int c : 31;
 };
+#endif
 
 struct B
 {
Index: pr41340.c
===================================================================
--- pr41340.c	(revision 154399)
+++ pr41340.c	(working copy)
@@ -2,6 +2,7 @@
 /* { dg-do compile } */
 /* { dg-options "-O3 -g -fcompare-debug" } */
 /* { dg-options "-O3 -g -fcompare-debug -march=i686" { target { { i?86-*-* x86_64-*-* } && ilp32 } } } */
+/* { dg-skip-if "no long pointers" {  { ! ilp32 } && { ! lp64 } } } */
 
 typedef struct { int t; } *T;
 struct S1 { unsigned s1; };
Index: profile-generate-3.c
===================================================================
--- profile-generate-3.c	(revision 154399)
+++ profile-generate-3.c	(working copy)
@@ -1,5 +1,6 @@
 /* { dg-do link } */
 /* { dg-options "-fprofile-generate=." } */
+/* { dg-require-profiling "-fprofile-generate=." } */
 
 int
 main ()

Re: [PATCH,TESTSUITE]Clean up for AVR and other small targets]

[Janis Johnson]

On Sat, 2009-11-21 at 12:01 -0500, Andrew Hutchinson wrote:
> The following patch cleans up tests for avr and other small integer targets.
> 
> 2009-11-21  Andy Hutchinson <hutchinsonandy@gcc.gnu.org>
> 
>     * gcc.dg/pr36998.c: Frame pointer required for avr target.
>     * gcc.dg/debug/pr41264-1.c: Use long if int size is 16bit or smaller.
>     * gcc.dg/pr39226.c: Use smaller bitfield if int size is 16bit.
>     * gcc.dg/pr41340.c: Test requires long pointer target.
>     * gcc.dg/profile-generate-3.c: Test requires profiling support.
> 
> Ok for 4.5 head?

OK, but move the dg-require-* directive before the dg-options
directives.  That goes for the ones I already approved, too, in
case I missed that in any of them.

Janis

Re: [PATCH,TESTSUITE]Clean up for AVR and other small targets]

[andrewhutchinson]

Thanks for approval.

I will move all "dg-require directive - though I note that many existing ones have it the other way around.

I'll also fix changelog nits. (Mostly Email playing  around with the inlined text.)


---- Janis Johnson <janis187@us.ibm.com> wrote: 
> On Sat, 2009-11-21 at 12:01 -0500, Andrew Hutchinson wrote:
> > The following patch cleans up tests for avr and other small integer targets.
> > 
> > 2009-11-21  Andy Hutchinson <hutchinsonandy@gcc.gnu.org>
> > 
> >     * gcc.dg/pr36998.c: Frame pointer required for avr target.
> >     * gcc.dg/debug/pr41264-1.c: Use long if int size is 16bit or smaller.
> >     * gcc.dg/pr39226.c: Use smaller bitfield if int size is 16bit.
> >     * gcc.dg/pr41340.c: Test requires long pointer target.
> >     * gcc.dg/profile-generate-3.c: Test requires profiling support.
> > 
> > Ok for 4.5 head?
> 
> OK, but move the dg-require-* directive before the dg-options
> directives.  That goes for the ones I already approved, too, in
> case I missed that in any of them.
> 
> Janis
>