From: Eric Botcazou <ebotcazou@adacore.com>
To: Bernd Schmidt <bernds_cb1@t-online.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: regrename speedup
Date: Tue, 24 Nov 2009 12:30:00 -0000 [thread overview]
Message-ID: <200911241328.26843.ebotcazou@adacore.com> (raw)
In-Reply-To: <4B0BBDA6.5030309@t-online.de>
> Ah. That looks a little buggy actually in the old version. Nevermind,
> here's a new set of patches.
Thanks. rr-cleanup2.diff is OK for mainline modulo the following nits:
+/* Undoes the substitution performed by hide_operands. INSN is the insn we
+ are processing; the arguments are the same as in hide_operands. */
"Undo the"
+/* For each output operands of INSN, call scan_rtx to create a new
+ open chain. */
"operand of"
+ struct du_head *prev_open = open_chains;
+
+ if (recog_data.operand_type[opn] == OP_OUT)
+ scan_rtx (insn, loc, cl, mark_write, OP_OUT);
+
+ /* ??? Many targets have output constraints on the SET_DEST
+ of a call insn, which is stupid, since these are certainly
+ ABI defined hard registers. For these, and for asm operands
+ that originally referenced hard registers, we must record that
+ the chain cannot be renamed. */
+ if (CALL_P (insn)
+ || (asm_noperands (PATTERN (insn)) > 0
+ && REG_P (op)
+ && REGNO (op) == ORIGINAL_REGNO (op)))
+ {
+ if (prev_open != open_chains)
+ open_chains->first->cl = NO_REGS;
+ }
I'd rewrite it as
struct du_head *prev_open;
if (recog_data.operand_type[opn] != OP_OUT)
continue;
prev_open = open_chains;
scan_rtx (insn, loc, cl, mark_write, OP_OUT);
to make things clearer.
I'll look into rr-full2.diff later today.
--
Eric Botcazou
next prev parent reply other threads:[~2009-11-24 12:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-17 14:46 Bernd Schmidt
2009-10-22 13:09 ` Eric Botcazou
2009-11-12 18:31 ` Bernd Schmidt
2009-11-28 1:39 ` H.J. Lu
2009-11-28 8:55 ` Eric Botcazou
2009-11-30 11:55 ` Bernd Schmidt
2009-11-30 12:19 ` Eric Botcazou
2009-11-30 13:27 ` Bernd Schmidt
2009-12-02 13:13 ` Bernd Schmidt
2009-12-02 18:22 ` Eric Botcazou
2009-12-03 13:08 ` Bernd Schmidt
2009-11-12 18:32 ` Bernd Schmidt
2009-11-19 19:28 ` Eric Botcazou
2009-11-20 1:36 ` Bernd Schmidt
2009-11-20 7:58 ` Eric Botcazou
2009-11-20 21:31 ` Bernd Schmidt
2009-11-22 22:26 ` Eric Botcazou
2009-11-24 11:55 ` Bernd Schmidt
2009-11-24 12:30 ` Eric Botcazou [this message]
2009-11-26 12:27 ` Eric Botcazou
2009-11-26 16:50 ` Bernd Schmidt
2009-11-26 17:46 ` Eric Botcazou
2009-11-26 23:19 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911241328.26843.ebotcazou@adacore.com \
--to=ebotcazou@adacore.com \
--cc=bernds_cb1@t-online.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).