public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: GCC Patches <gcc-patches@gcc.gnu.org>,
	Jan Hubicka <hubicka@ucw.cz>,
		Richard Guenther <rguenther@suse.de>
Subject: Re: [PATCH] Reorder fields in struct cgraph_edge et al
Date: Tue, 01 Dec 2009 01:55:00 -0000	[thread overview]
Message-ID: <20091201015514.GI20144@kam.mff.cuni.cz> (raw)
In-Reply-To: <20091130204143.GF12510@virgil.suse.cz>

> Hi,
> 
> I have noticed that struct cgraph_edge is currently misaligned by one
> bit.  This patch fixes that by making loop_nest an unsigned short, and
> so leaving plenty of bits available for future flags.  When doing so,
> I also reordered the fields according to their size which should also
> decrease the size of the structure.  Then I did the same thing with a
> very similar structure in ipa-prop.h, namely param_call_note.
> Finally, because I have noticed that loop_nest is not set, I fixed
> that.
> 
> I have bootstrapped and tested this on x86_64-linux.  I seek
> permission to commit this to trunk despite stage 4 looming on the
> horizon.  (Fortunately I do not have any more patches like this :-)

This is OK.  Thanks!
Honza

  reply	other threads:[~2009-12-01  1:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30 20:47 Martin Jambor
2009-12-01  1:55 ` Jan Hubicka [this message]
2009-12-01  9:47 ` Richard Guenther
2009-12-01 10:57   ` Martin Jambor
2009-12-01 11:29     ` Richard Guenther
2009-12-01 11:33       ` Martin Jambor
2009-12-01 11:40         ` Richard Guenther
2009-12-02 12:02           ` Martin Jambor
2009-12-02 21:46             ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091201015514.GI20144@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).