From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20208 invoked by alias); 1 Dec 2009 10:56:36 -0000 Received: (qmail 20199 invoked by uid 22791); 1 Dec 2009 10:56:35 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Dec 2009 10:56:30 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) by mx2.suse.de (Postfix) with ESMTP id 7067979727; Tue, 1 Dec 2009 11:56:28 +0100 (CET) Date: Tue, 01 Dec 2009 10:57:00 -0000 From: Martin Jambor To: Richard Guenther Cc: GCC Patches , Jan Hubicka Subject: Re: [PATCH] Reorder fields in struct cgraph_edge et al Message-ID: <20091201105627.GA4389@virgil.suse.cz> Mail-Followup-To: Richard Guenther , GCC Patches , Jan Hubicka References: <20091130204143.GF12510@virgil.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-12/txt/msg00041.txt.bz2 Hi, On Tue, Dec 01, 2009 at 10:46:33AM +0100, Richard Guenther wrote: > On Mon, 30 Nov 2009, Martin Jambor wrote: > ... > > 2009-11-30 Martin Jambor > > > > * cgraph.h (GTY): Reorder fields. Make loop_nest unsigned short int. > > * ipa-prop.h (struct ipa_param_call_note): Likewise. > > * ipa-prop.c (ipa_note_param_call): Set note->loop_nest. > > > > Index: icln/gcc/cgraph.h > > =================================================================== > > --- icln.orig/gcc/cgraph.h > > +++ icln/gcc/cgraph.h > > @@ -310,6 +310,8 @@ typedef enum { > > } cgraph_inline_failed_t; > > > > struct GTY((chain_next ("%h.next_caller"), chain_prev ("%h.prev_caller"))) cgraph_edge { > > + /* Expected number of executions: calculated in profile.c. */ > > + gcov_type count; > > you now have introduced 32bit padding here ... > ... > > moving this is ok, please leave count where it is > ... > > + /* Expected number of executions: calculated in profile.c. */ > > + gcov_type count; > > Likewise. gcov_type is 32bit. > No, even on i386 gcov_type is 64 bit. I have just double checked. I have committed the patch as it was per Honza's approval. Martin > Ok with that chagnes. > > Richard. > > > /* Linked list's next */ > > struct ipa_param_call_note *next; > > /* Statement that contains the call to the parameter above. */ > > @@ -147,13 +149,11 @@ struct ipa_param_call_note > > unsigned int lto_stmt_uid; > > /* Index of the parameter that is called. */ > > int formal_id; > > - /* Expected number of executions: calculated in profile.c. */ > > - gcov_type count; > > /* Expected frequency of executions within the function. see cgraph_edge in > > cgraph.h for more on this. */ > > int frequency; > > /* Depth of loop nest, 1 means no loop nest. */ > > - int loop_nest; > > + unsigned short int loop_nest; > > /* Set when we have already found the target to be a compile time constant > > and turned this into an edge or when the note was found unusable for some > > reason. */ > > > >