From: Arnaud Charlet <charlet@adacore.com>
To: Simon Wright <simon@pushface.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR ada/42254, avoid providing multiple copies of object files to link of GNAT tools
Date: Mon, 01 Feb 2010 07:23:00 -0000 [thread overview]
Message-ID: <20100201072324.GA90938@adacore.com> (raw)
In-Reply-To: <F8682F01-C8FE-4381-BFE5-5B1E69211BB8@pushface.org>
> Anyway, in the interests of at least being able to build the compiler, I've tested
> on x86_64-apple-darwin10, i686-apple-darwin10, x86_64-unknown-linux-gnu
> [Debian 5] and powerpc-wrs-vxworks hosted on i686-apple-darwin10.
You've broken this line:
-TEXI2PDF = texi2pdf
+EXI2PDF = texi2pdf
Also, you've duplicated the same comment in two places, which is not
desirable.
And you mention that the dummy setting of TOOLS_GNATLIBC and TOOLS_NOSTDLIB
is for darwin only. Would be better to document in a general way how/when
these variables should be set.
> 2010-01-31 Simon Wright <simon@pushface.org>
> PR ada/42554
> * gcc-interface/Makefile.in (TOOLS_LIBS, GNATLINK_OBJS,
> GNATMAKE_OBJS, common-tools, ../../gnatmake$(exeext),
> ../../gnatlink$(exeext), gnatmake-re, gnatlink-re): on
> Darwin, ensure that the linker only sees each object file
> once.
Arno
next prev parent reply other threads:[~2010-02-01 7:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 21:30 Simon Wright
2010-01-26 21:45 ` Arnaud Charlet
2010-01-26 22:09 ` Simon Wright
2010-01-26 22:45 ` Arnaud Charlet
2010-01-28 6:07 ` Simon Wright
2010-01-28 9:39 ` Arnaud Charlet
2010-01-28 22:52 ` Simon Wright
2010-01-29 9:17 ` Arnaud Charlet
2010-01-31 22:54 ` Simon Wright
2010-02-01 7:23 ` Arnaud Charlet [this message]
2010-02-03 6:59 ` Simon Wright
2010-01-26 21:30 Simon Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100201072324.GA90938@adacore.com \
--to=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=simon@pushface.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).