From: Jakub Jelinek <jakub@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: RFA: PATCH to expand_used_vars for debug/42800
Date: Fri, 19 Feb 2010 22:34:00 -0000 [thread overview]
Message-ID: <20100219224109.GI2817@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <4B7F0E4E.4090902@redhat.com>
On Fri, Feb 19, 2010 at 05:18:54PM -0500, Jason Merrill wrote:
> The problem is this PR is that when are writing out the debug info
> for the temporary containing the upper bound of the VLA, its rtl
> still refers to virtual regs, so dwarf2out gives up and doesn't emit
> any debug info for the upper bound. This happens because the Expand
> from SSA patch broke Jakub's patch for PR 34037, such that
> expand_used_vars is no longer re-adding the variable to
> cfun->local_decls.
>
> The patch adjusts the logic in expand_used_vars so that the PR 34037
> fix is executed again for this variable.
>
> I have also attached a second (alternative) patch which fixes the
> symptom by calling instantiate_decl_rtl from dwarf2out. This patch
> is lower in impact, but I think the first patch is safe enough that
> we don't need to be this conservative.
I'd prefer the first patch. Reminds me we should attempt to do something
useful even for -O+ (make sure we have a debug stmt/DEBUG_INSN for the
bounds and that var-tracking tracks even these artificial vars.
Jakub
next prev parent reply other threads:[~2010-02-19 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 22:19 Jason Merrill
2010-02-19 22:34 ` Jakub Jelinek [this message]
2010-02-22 22:26 ` PING: PATCH to expand_used_vars for debug/42800 (P1 regression) Jason Merrill
2010-02-23 10:44 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219224109.GI2817@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).