From: Jan Hubicka <hubicka@ucw.cz>
To: Martin Jambor <mjambor@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH 1/6] Clarify edge redirection for inline clones
Date: Mon, 22 Feb 2010 14:23:00 -0000 [thread overview]
Message-ID: <20100222142216.GC3140@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20100213180156.993252867@alvy.suse.cz>
>
> 2010-02-12 Martin Jambor <mjambor@suse.cz>
>
> * cgraph.h (cgraph_redirect_edge_call_stmt_to_callee): Declare.
> * cgraphunit.c (cgraph_materialize_all_clones): Moved call
> redirection...
> (cgraph_redirect_edge_call_stmt_to_callee): ...to this new
> function.
> (verify_cgraph_node): Do not check for edges pointing to wrong
> nodes in inline clones.
> * tree-inline.c (copy_bb): Call
> cgraph_redirect_edge_call_stmt_to_callee.
As we discussed earlier, it would make most sense to redirect calls just before inlining
visits them, but this should work on mainline well. So the patch is OK for pretty-ipa and
if you can find a testcase producing ICE at mainline, then for mainlie too.
Honza
next prev parent reply other threads:[~2010-02-22 14:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 18:03 [PATCH 0/6] Cgraph changes and various devirtualizations Martin Jambor
2010-02-13 18:03 ` [PATCH 1/6] Clarify edge redirection for inline clones Martin Jambor
2010-02-22 14:23 ` Jan Hubicka [this message]
2010-02-13 18:04 ` [PATCH 6/6] Devirtualization in ipa-cp Martin Jambor
2010-02-22 16:37 ` Jan Hubicka
2010-03-11 13:42 ` Martin Jambor
2010-02-13 18:04 ` [PATCH 5/6] Indirect inlining of virtual calls Martin Jambor
2010-02-22 16:49 ` Jan Hubicka
2010-03-10 13:45 ` Martin Jambor
2010-03-10 15:24 ` Jan Hubicka
2010-02-13 18:04 ` [PATCH 3/6] Folding " Martin Jambor
2010-02-13 18:12 ` Richard Guenther
2010-02-13 18:04 ` [PATCH 4/6] Remove unused ipa_note_param_call.called flag (approved) Martin Jambor
2010-02-13 18:14 ` Richard Guenther
2010-03-05 16:19 ` Martin Jambor
2010-02-22 15:04 ` Jan Hubicka
2010-02-13 18:04 ` [PATCH 2/6] Indirect call graph edges Martin Jambor
2010-02-13 18:17 ` Richard Guenther
2010-02-13 18:25 ` Richard Guenther
2010-03-05 17:06 ` Martin Jambor
2010-02-22 15:52 ` Jan Hubicka
2010-02-22 16:05 ` Richard Guenther
2010-02-22 16:06 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100222142216.GC3140@atrey.karlin.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).