From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6243 invoked by alias); 22 Feb 2010 14:22:23 -0000 Received: (qmail 6228 invoked by uid 22791); 22 Feb 2010 14:22:22 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_05 X-Spam-Check-By: sourceware.org Received: from ksp.mff.cuni.cz (HELO atrey.karlin.mff.cuni.cz) (195.113.26.206) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Feb 2010 14:22:18 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4018) id 5BA10F02C6; Mon, 22 Feb 2010 15:22:16 +0100 (CET) Date: Mon, 22 Feb 2010 14:23:00 -0000 From: Jan Hubicka To: Martin Jambor Cc: GCC Patches , Jan Hubicka Subject: Re: [PATCH 1/6] Clarify edge redirection for inline clones Message-ID: <20100222142216.GC3140@atrey.karlin.mff.cuni.cz> References: <20100213180136.555197900@alvy.suse.cz> <20100213180156.993252867@alvy.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100213180156.993252867@alvy.suse.cz> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-02/txt/msg00873.txt.bz2 > > 2010-02-12 Martin Jambor > > * cgraph.h (cgraph_redirect_edge_call_stmt_to_callee): Declare. > * cgraphunit.c (cgraph_materialize_all_clones): Moved call > redirection... > (cgraph_redirect_edge_call_stmt_to_callee): ...to this new > function. > (verify_cgraph_node): Do not check for edges pointing to wrong > nodes in inline clones. > * tree-inline.c (copy_bb): Call > cgraph_redirect_edge_call_stmt_to_callee. As we discussed earlier, it would make most sense to redirect calls just before inlining visits them, but this should work on mainline well. So the patch is OK for pretty-ipa and if you can find a testcase producing ICE at mainline, then for mainlie too. Honza