Re: [PATCH 4/6] Remove unused ipa_note_param_call.called flag (approved)

[Martin Jambor <mjambor@suse.cz>]

Hi,

On Sat, Feb 13, 2010 at 07:14:05PM +0100, Richard Guenther wrote:
> On Sat, Feb 13, 2010 at 7:01 PM, Martin Jambor <mjambor@suse.cz> wrote:
> > This patch is a minor cleanup.  I have realized that the called flag
> > in the ipa-prop parameter descriptor is not used and I could not
> > really think how the flag can be obviously useful in a short-term
> > either so I removed it.
> >
> > I have bootstrapped and tested this change along with the next one in
> > the series.
> >
> > The patch has already been approved by Honza but this is its place in
> > the series and so I re-send it along.
> 
> If this applies independently of the rest of the series it is ok for the trunk
> at this stage.
> 

OK, I have moved this patch to the beginning of the queue which
required some minor changes.  I will commit the patch below if there
are no objections in the next few hours.

Yes, I have re-bootstrapped and re-tested the patch.

Thanks,

Martin


2010-03-05  Martin Jambor  <mjambor@suse.cz>

	* ipa-prop.h (struct ipa_param_descriptor): Removed the called field.
	(ipa_is_param_called): Removed.
	* ipa-prop.c (ipa_note_param_call): Do not set the called flag.
	(ipa_print_node_params): Do not print the called flag.
	(ipa_write_node_info): Do not stream the called flag.
	(ipa_read_node_info): Likewise.

Index: icln/gcc/ipa-prop.c
===================================================================
--- icln.orig/gcc/ipa-prop.c
+++ icln/gcc/ipa-prop.c
@@ -746,8 +746,6 @@ ipa_note_param_call (struct ipa_node_par
   struct ipa_param_call_note *note;
   basic_block bb = gimple_bb (stmt);
 
-  info->params[formal_id].called = 1;
-
   note = XCNEW (struct ipa_param_call_note);
   note->formal_id = formal_id;
   note->stmt = stmt;
@@ -1425,8 +1423,6 @@ ipa_print_node_params (FILE * f, struct
                   : "(unnamed)"));
       if (ipa_is_param_modified (info, i))
 	fprintf (f, " modified");
-      if (ipa_is_param_called (info, i))
-	fprintf (f, " called");
       fprintf (f, "\n");
     }
 }
@@ -2024,10 +2020,7 @@ ipa_write_node_info (struct output_block
   gcc_assert (!info->node_enqueued);
   gcc_assert (!info->ipcp_orig_node);
   for (j = 0; j < ipa_get_param_count (info); j++)
-    {
-      bp_pack_value (bp, info->params[j].modified, 1);
-      bp_pack_value (bp, info->params[j].called, 1);
-    }
+    bp_pack_value (bp, info->params[j].modified, 1);
   lto_output_bitpack (ob->main_stream, bp);
   bitpack_delete (bp);
   for (e = node->callees; e; e = e->next_callee)
@@ -2071,10 +2064,7 @@ ipa_read_node_info (struct lto_input_blo
     }
   info->node_enqueued = false;
   for (k = 0; k < ipa_get_param_count (info); k++)
-    {
-      info->params[k].modified = bp_unpack_value (bp, 1);
-      info->params[k].called = bp_unpack_value (bp, 1);
-    }
+    info->params[k].modified = bp_unpack_value (bp, 1);
   bitpack_delete (bp);
   for (e = node->callees; e; e = e->next_callee)
     {
Index: icln/gcc/ipa-prop.h
===================================================================
--- icln.orig/gcc/ipa-prop.h
+++ icln/gcc/ipa-prop.h
@@ -169,8 +169,6 @@ struct ipa_param_descriptor
   tree decl;
   /* Whether the value parameter has been modified within the function.  */
   unsigned modified : 1;
-  /* Whether the parameter has been used as a call destination. */
-  unsigned called : 1;
 };
 
 /* ipa_node_params stores information related to formal parameters of functions
@@ -248,17 +246,6 @@ ipa_is_param_modified (struct ipa_node_p
   return info->params[i].modified;
 }
 
-/* Return the called flag corresponding to the Ith formal parameter of the
-   function associated with INFO.  Note that there is no setter method as the
-   goal is to set all flags when building the array in
-   ipa_detect_called_params.  */
-
-static inline bool
-ipa_is_param_called (struct ipa_node_params *info, int i)
-{
-  return info->params[i].called;
-}
-
 /* Flag this node as having callers with variable number of arguments.  */
 
 static inline void