From: Arnaud Charlet <charlet@adacore.com>
To: Duncan Sands <baldrick@free.fr>
Cc: Eric Botcazou <ebotcazou@adacore.com>, gcc-patches@gcc.gnu.org
Subject: Re: [Ada] Delete bogus use of flag_zero_initialized_in_bss
Date: Tue, 16 Mar 2010 09:34:00 -0000 [thread overview]
Message-ID: <20100316092123.GA77854@adacore.com> (raw)
In-Reply-To: <4B9F4BDA.50101@free.fr>
>> Yes, that's precisely why the flag needs to be cleared: uninitialized really
>> means uninitialized in Ada so the BSS section isn't guaranteed to be zero-ed
>> at startup for a pure Ada program.
>
> on most systems (such as linux) it is the O/S that takes care of ensuring the
> BSS section is filled with zeros, so I don't see how being an Ada program is
> relevant.
Not all systems behave this way, and not all systems are Linux systems, in
particular embedded systems. The patch is indeed not OK.
BTW for the future, you forgot to include a proper ChangeLog for your
patch.
Arno
next prev parent reply other threads:[~2010-03-16 9:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 8:58 Duncan Sands
2010-03-16 9:06 ` Eric Botcazou
2010-03-16 9:21 ` Duncan Sands
2010-03-16 9:34 ` Arnaud Charlet [this message]
2010-03-16 9:37 ` Duncan Sands
2010-03-16 10:20 ` Arnaud Charlet
2010-03-16 16:08 ` Eric Botcazou
2010-03-16 17:00 ` Duncan Sands
2010-03-16 22:26 ` Eric Botcazou
2010-03-18 14:06 ` Duncan Sands
2010-03-18 15:26 ` Eric Botcazou
2010-04-15 13:10 ` Florian Weimer
2010-04-15 16:59 ` Eric Botcazou
2010-04-15 17:13 ` Florian Weimer
2010-04-15 17:40 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100316092123.GA77854@adacore.com \
--to=charlet@adacore.com \
--cc=baldrick@free.fr \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).