From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30964 invoked by alias); 6 May 2010 17:59:46 -0000 Received: (qmail 30948 invoked by uid 22791); 6 May 2010 17:59:44 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 May 2010 17:59:40 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o46HxGTX005729 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 May 2010 13:59:17 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o46HxFLG007205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 6 May 2010 13:59:16 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.3/8.14.3) with ESMTP id o46I6qTq023373; Thu, 6 May 2010 20:06:52 +0200 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.3/8.14.3/Submit) id o46I6pEC023371; Thu, 6 May 2010 20:06:51 +0200 Date: Thu, 06 May 2010 17:59:00 -0000 From: Jakub Jelinek To: Ralf Wildenhues , Eric Botcazou , Magnus Granberg , gcc-patches@gcc.gnu.org Subject: Re: [patch] Add new warning -Wtrampolines Message-ID: <20100506180650.GV2817@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <201005060146.34151.zorry@gentoo.org> <201005060924.46313.ebotcazou@adacore.com> <20100506171154.GA11419@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100506171154.GA11419@gmx.de> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-05/txt/msg00416.txt.bz2 On Thu, May 06, 2010 at 07:11:54PM +0200, Ralf Wildenhues wrote: > * Eric Botcazou wrote on Thu, May 06, 2010 at 09:24:46AM CEST: > > > This patch add new warning -Wtrampolines for making the compile to warn > > > when it generating trampoline in object that requires executable stack. > > > As Andrew pointed out, the wording of the warning isn't correct for all > > platforms (IA-64 for example) so it needs to be rephrased, e.g: > > If it needs to be rephrased anyway, why not make it -Wexecutable-stack > instead? Isn't it that the part that is interesting here? Wouldn't it be better then to warn in the linker when setting PT_GNU_STACK to PF_X? That wouldn't cover just the case where GCC compiled objects need trampolines, but where assembly needs them (or hasn't been mistakenly marked as not needing them). Jakub