[patch] Move C front end to its own directory (1/3)

[patch] Move C front end to its own directory (1/3)

[Steven Bosscher]

[-- Attachment #1: Type: text/plain, Size: 5013 bytes --]

Hello,

This is the first patch of 3 planned, to move the C front end to its
own directory. The patches implement the plan from Joseph from long
ago (http://gcc.gnu.org/ml/gcc/2004-09/msg00695.html).

This first patch moves all the code common to the C-family of front
ends to a new directory c-family/.  I have not included the part of
the diff for moving the files, just the svn commands I used to move
the files.

(The second patch will move the C front end specific files. The third
file will move the Makefile bits of c-family/ to that directory, but
I'm not sure yet how to do that. Extra follow-ups could split up
c-common.? but I have no plans for that.)

Most of this is trivial updating of paths. The only complication is
that gengtype does not understand that files can come from
subdirectories that are not front-end specific, so I needed a rather
ugly hack there.  Otherwise, as I said: rather mechanical.

Bootstrapped&tested on x86_64-unknown-linux-gnu.
OK for trunk?

Ciao!
Steven


gcc/ChangeLog:
        * c-common.c: Move to c-family/.
        * c-common.def: Likewise.
        * c-common.h: Likewise.
        * c-cppbuiltin.c: Likewise.
        * c-dump.c: Likewise.
        * c-format.c: Likewise.
        * c-format.h : Likewise.
        * c-gimplify.c: Likewise.
        * c-lex.c: Likewise.
        * c-omp.c: Likewise.
        * c.opt: Likewise.
        * c-opts.c: Likewise.
        * c-pch.c: Likewise.
        * c-ppoutput.c: Likewise.
        * c-pragma.c: Likewise.
        * c-pragma.h: Likewise.
        * c-pretty-print.c: Likewise.
        * c-pretty-print.h: Likewise.
        * c-semantics.c: Likewise.
        * stub-objc.c: Likewise.

        * gengtype.c (get_file_langdir): Special-case files in c-family/.
        (get_output_file_with_visibility): Fix name for c-common.h.
        * c-config-lang.in: Update paths in gtfiles for files in c-family/.

        * c-lang.c: Update include path for moved files.
        * c-lang.h: Likewise.
        * c-parser.c: Likewise.
        * c-convert.c: Likewise.
        * configure.ac: Make sure c-family/ exists in the build directory.
        * configure: Regenerate.
        * Makefile.in: Update paths for moved files.  Regroup files per
        location and update dependencies.  Move generated_files down after
        ALL_GTFILES_H.

        * config/spu/spu-c.c: Update paths for moved files.
        * config/mep/mep-pragma.c: Likewise.
        * config/darwin-c.c: Likewise.
        * config/i386/msformat-c.c: Likewise.
        * config/i386/i386-c.c: Likewise.
        * config/avr/avr-c.c: Likewise.
        * config/sol2-c.c: Likewise.
        * config/ia64/ia64-c.c: Likewise.
        * config/rs6000/rs6000-c.c: Likewise.
        * config/arm/arm.c: Likewise.
        * config/arm/arm-c.c: Likewise.
        * config/h8300/h8300.c: Likewise.
        * config/v850/v850-c.c: Likewise.

        * config/t-darwin: Fix dependencies for moved files.
        * config/t-sol2: Fix dependencies for moved files.
        * config/mep/t-mep: Fix dependencies for moved files.
        * config/ia64/t-ia64: Fix dependencies for moved files.
        * config/rs6000/t-rs6000: Fix dependencies for moved files.
        * config/v850/t-v850: Fix dependencies for moved files.
        * config/v850/t-v850e: Fix dependencies for moved files.

        * config/m32c/m32c-pragma.c

c-family/ChangeLog:
        * c-family/c-common.c: Include gt-c-family-c-common.h.
        * c-family/c-pragma.c: Include gt-c-family-c-pragma.h.

objc/ChangeLog:
        * objc/objc-act.c: Update include path for moved files.
        * objc/objc-lang.c: Likewise.
        * objc/config-lang.in: Update paths in gtfiles for files in c-family/.

objcp/ChangeLog:
        * objcp/objcp-lang.c: Update include path for moved files.
        * objcp/config-lang.in: Update paths in gtfiles for files in c-family/.

cp/ChangeLog:
        * cp/typeck.c: Update include path for moved files.
        * cp/decl.c: Likewise.
        * cp/rtti.c: Likewise.
        * cp/cp-gimplify.c: Likewise.
        * cp/cp-lang.c: Likewise.
        * cp/pt.c: Likewise.
        * cp/semantics.c: Likewise.
        * cp/cxx-pretty-print.h: Likewise.
        * cp/decl2.c: Likewise.
        * cp/parser.c: Likewise.
        * cp/cp-objcp-common.c: Likewise.
        * cp/cp-tree.h: Likewise.
        * cp/name-lookup.c: Likewise.
        * cp/lex.c: Likewise.
        * cp/name-lookup.h: Likewise.
        * cp/config-lang.in: Update paths in gtfiles for files in c-family/.
        * cp/Make-lang.in: Likewise.

for f in c-common.c \
        c-common.def \
        c-common.h \
        c-cppbuiltin.c \
        c-dump.c \
        c-format.c \
        c-format.h \
        c-gimplify.c \
        c-lex.c \
        c-omp.c \
        c.opt \
        c-opts.c \
        c-pch.c \
        c-ppoutput.c \
        c-pragma.c \
        c-pragma.h \
        c-pretty-print.c \
        c-pretty-print.h \
        c-semantics.c \
        stub-objc.c ; do
  svn mv $f c-family/ ;
done

[-- Attachment #2: move_c_fe_1.diff.gz --]
[-- Type: application/x-gzip, Size: 9611 bytes --]

Re: [patch] Move C front end to its own directory (1/3)

[Mark Mitchell]

Steven Bosscher wrote:

> gcc/ChangeLog:
>         * c-common.c: Move to c-family/.
...

I will pre-approve all of the mechanical changes to path updates such.
In other words, if Joseph approves the changes to the C front end per
se, the mechanical aspects throughout the rest of the compiler to adjust
to those changes are OK.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

Re: [patch] Move C front end to its own directory (1/3)

[Steven Bosscher]

[-- Attachment #1: Type: text/plain, Size: 4934 bytes --]

On Sat, May 29, 2010 at 11:28 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> Hello,
>
> This is the first patch of 3 planned, to move the C front end to its
> own directory. The patches implement the plan from Joseph from long
> ago (http://gcc.gnu.org/ml/gcc/2004-09/msg00695.html).
>
> This first patch moves all the code common to the C-family of front
> ends to a new directory c-family/.  I have not included the part of
> the diff for moving the files, just the svn commands I used to move
> the files.
>
> (The second patch will move the C front end specific files. The third
> file will move the Makefile bits of c-family/ to that directory, but
> I'm not sure yet how to do that. Extra follow-ups could split up
> c-common.? but I have no plans for that.)
>
> Most of this is trivial updating of paths. The only complication is
> that gengtype does not understand that files can come from
> subdirectories that are not front-end specific, so I needed a rather
> ugly hack there.  Otherwise, as I said: rather mechanical.
>

This is an updated patch for trunk today.

Bootstrapped&tested on x86_64-unknown-linux-gnu.
OK for trunk?

Ciao!
Steven

gcc/ChangeLog:
        * c-common.c: Move to c-family/.
        * c-common.def: Likewise.
        * c-common.h: Likewise.
        * c-cppbuiltin.c: Likewise.
        * c-dump.c: Likewise.
        * c-format.c: Likewise.
        * c-format.h : Likewise.
        * c-gimplify.c: Likewise.
        * c-lex.c: Likewise.
        * c-omp.c: Likewise.
        * c.opt: Likewise.
        * c-opts.c: Likewise.
        * c-pch.c: Likewise.
        * c-ppoutput.c: Likewise.
        * c-pragma.c: Likewise.
        * c-pragma.h: Likewise.
        * c-pretty-print.c: Likewise.
        * c-pretty-print.h: Likewise.
        * c-semantics.c: Likewise.
        * stub-objc.c: Likewise.

        * gengtype.c (get_file_langdir): Special-case files in c-family/.
        (get_output_file_with_visibility): Fix name for c-common.h.
        * c-config-lang.in: Update paths in gtfiles for files in c-family/.

        * c-tree.h: Update include path for moved files.
        * c-lang.c: Likewise.
        * c-lang.h: Likewise.
        * c-parser.c: Likewise.
        * c-convert.c: Likewise.
        * c-decl.c: Likewise.
        * c-objc-common.c: Likewise.
        * configure.ac: Make sure c-family/ exists in the build directory.
        * configure: Regenerate.
        * Makefile.in: Update paths for moved files.  Regroup files per
        location and update dependencies.  Move generated_files down after
        ALL_GTFILES_H.

        * config/spu/spu-c.c: Update paths for moved files.
        * config/mep/mep-pragma.c: Likewise.
        * config/darwin-c.c: Likewise.
        * config/i386/msformat-c.c: Likewise.
        * config/i386/i386-c.c: Likewise.
        * config/avr/avr-c.c: Likewise.
        * config/sol2-c.c: Likewise.
        * config/ia64/ia64-c.c: Likewise.
        * config/rs6000/rs6000-c.c: Likewise.
        * config/arm/arm.c: Likewise.
        * config/arm/arm-c.c: Likewise.
        * config/h8300/h8300.c: Likewise.
        * config/v850/v850-c.c: Likewise.

        * config/t-darwin: Fix dependencies for moved files.
        * config/t-sol2: Fix dependencies for moved files.
        * config/mep/t-mep: Fix dependencies for moved files.
        * config/ia64/t-ia64: Fix dependencies for moved files.
        * config/rs6000/t-rs6000: Fix dependencies for moved files.
        * config/v850/t-v850: Fix dependencies for moved files.
        * config/v850/t-v850e: Fix dependencies for moved files.

        * config/m32c/m32c-pragma.c

c-family/ChangeLog:
        * c-family/c-common.c: Include gt-c-family-c-common.h.
        * c-family/c-pragma.c: Include gt-c-family-c-pragma.h.

objc/ChangeLog:
        * objc/objc-act.c: Update include path for moved files.
        * objc/objc-lang.c: Likewise.
        * objc/config-lang.in: Update paths in gtfiles for files in c-family/.

objcp/ChangeLog:
        * objcp/objcp-lang.c: Update include path for moved files.
        * objcp/config-lang.in: Update paths in gtfiles for files in c-family/.

cp/ChangeLog:
        * cp/typeck.c: Update include path for moved files.
        * cp/decl.c: Likewise.
        * cp/rtti.c: Likewise.
        * cp/cp-gimplify.c: Likewise.
        * cp/cp-lang.c: Likewise.
        * cp/pt.c: Likewise.
        * cp/semantics.c: Likewise.
        * cp/cxx-pretty-print.h: Likewise.
        * cp/decl2.c: Likewise.
        * cp/parser.c: Likewise.
        * cp/cp-objcp-common.c: Likewise.
        * cp/cp-tree.h: Likewise.
        * cp/name-lookup.c: Likewise.
        * cp/lex.c: Likewise.
        * cp/name-lookup.h: Likewise.
        * cp/config-lang.in: Update paths in gtfiles for files in c-family/.
        * cp/Make-lang.in: Likewise.

[-- Attachment #2: move_c_fe_1.diff.gz --]
[-- Type: application/x-gzip, Size: 10012 bytes --]

Re: [patch] Move C front end to its own directory (1/3)

[Steven Bosscher]

On Fri, Jun 4, 2010 at 10:51 AM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> This is an updated patch for trunk today.

...if I had sent the right patch. You need these bits also:

diff -u cp/decl2.c cp/decl2.c
--- cp/decl2.c  (working copy)
+++ cp/decl2.c  (working copy)
@@ -53,7 +53,7 @@
 #include "pointer-set.h"
 #include "splay-tree.h"
 #include "langhooks.h"
-#include "c-ada-spec.h"
+#include "c-family/c-ada-spec.h"

 extern cpp_reader *parse_in;

diff -u cp/Make-lang.in cp/Make-lang.in
--- cp/Make-lang.in     (working copy)
+++ cp/Make-lang.in     (working copy)
@@ -258,7 +258,7 @@
 cp/decl2.o: cp/decl2.c $(CXX_TREE_H) $(TM_H) $(FLAGS_H) cp/decl.h \
   output.h $(EXCEPT_H) toplev.h $(C_COMMON_H) gt-cp-decl2.h $(CGRAPH_H) \
   $(C_PRAGMA_H) $(TREE_DUMP_H) intl.h $(TARGET_H) $(GIMPLE_H)
$(POINTER_SET_H) \
-  $(SPLAY_TREE_H) c-ada-spec.h
+  $(SPLAY_TREE_H) c-family/c-ada-spec.h
 cp/cp-objcp-common.o : cp/cp-objcp-common.c $(CONFIG_H) $(SYSTEM_H) \
   coretypes.h $(TM_H) $(TREE_H) $(CXX_TREE_H) $(C_COMMON_H) toplev.h \
   langhooks.h $(LANGHOOKS_DEF_H) $(DIAGNOSTIC_H) debug.h \

Re: [patch] Move C front end to its own directory (1/3)

[Joseph S. Myers]

On Fri, 4 Jun 2010, Steven Bosscher wrote:

> This is an updated patch for trunk today.
> 
> Bootstrapped&tested on x86_64-unknown-linux-gnu.
> OK for trunk?

The C changes are OK together with the po/exgettext fix.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [patch] Move C front end to its own directory (1/3)

[Joseph S. Myers]

On Sat, 29 May 2010, Steven Bosscher wrote:

> Most of this is trivial updating of paths. The only complication is
> that gengtype does not understand that files can come from
> subdirectories that are not front-end specific, so I needed a rather

Neither does po/exgettext, which looks for directories with config-lang.in 
plus the config/ directory and its immediate subdirectories.  So that 
script will need to know about c-family as well.  (This limitation could 
be turned into a feature: if target-side files moved to the toplevel 
libgcc directory, generator files to a subdirectory of gcc/ and targets 
using mips-tdump or mips-tfile were deprecated, then po/EXCLUDES would no 
longer be needed.)

I have not yet otherwise reviewed the patch.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [patch] Move C front end to its own directory (1/3)

[Steven Bosscher]

On Sat, Jun 5, 2010 at 12:26 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Sat, 29 May 2010, Steven Bosscher wrote:
>
>> Most of this is trivial updating of paths. The only complication is
>> that gengtype does not understand that files can come from
>> subdirectories that are not front-end specific, so I needed a rather
>
> Neither does po/exgettext, which looks for directories with config-lang.in
> plus the config/ directory and its immediate subdirectories.  So that
> script will need to know about c-family as well.

OK, that is not very difficult, the following patch would suffice for now:
-------------------- 8< -----------------------
Index: po/exgettext
===================================================================
--- po/exgettext	(revision 160279)
+++ po/exgettext	(working copy)
@@ -84,7 +84,7 @@ echo "scanning for keywords, %e and %n s

 ( cd $srcdir
   lang_subdirs=`echo */config-lang.in */*/config-lang.in | sed -e
's|config-lang\.in||g'`
-  { for dir in "" config/ config/*/ $lang_subdirs
+  { for dir in "" c-family/ config/ config/*/ $lang_subdirs
     do  for glob in '*.c' '*.h' '*.def'
         do  eval echo $dir$glob
         done
-------------------- 8< -----------------------


(Longer term, we would have to add support for subdirectories in
general, i.e. not just the lang_subdirs, if more files would be moved
from gcc/ to separate directories, e.g. all GIMPLE optimizations. But
for now, one extra hard-coded directory is not a real problem, is it?)

>
> I have not yet otherwise reviewed the patch.

Note that there is really not so *that* to review. I think the most
important bits of the patch (and the hardest to keep in sync until the
patch is approved) are the Makefile.in bits. Eventually I think there
should be a separate Make* file in c-family/ but that is for a later
patch (again, we'll need some form of support for subdirectories in
general).

Ciao!
Steven

Re: [patch] Move C front end to its own directory (1/3)

[Richard Guenther]

On Sat, Jun 5, 2010 at 3:29 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Sat, Jun 5, 2010 at 12:26 PM, Joseph S. Myers
> <joseph@codesourcery.com> wrote:
>> On Sat, 29 May 2010, Steven Bosscher wrote:
>>
>>> Most of this is trivial updating of paths. The only complication is
>>> that gengtype does not understand that files can come from
>>> subdirectories that are not front-end specific, so I needed a rather
>>
>> Neither does po/exgettext, which looks for directories with config-lang.in
>> plus the config/ directory and its immediate subdirectories.  So that
>> script will need to know about c-family as well.
>
> OK, that is not very difficult, the following patch would suffice for now:
> -------------------- 8< -----------------------
> Index: po/exgettext
> ===================================================================
> --- po/exgettext        (revision 160279)
> +++ po/exgettext        (working copy)
> @@ -84,7 +84,7 @@ echo "scanning for keywords, %e and %n s
>
>  ( cd $srcdir
>   lang_subdirs=`echo */config-lang.in */*/config-lang.in | sed -e
> 's|config-lang\.in||g'`
> -  { for dir in "" config/ config/*/ $lang_subdirs
> +  { for dir in "" c-family/ config/ config/*/ $lang_subdirs
>     do  for glob in '*.c' '*.h' '*.def'
>         do  eval echo $dir$glob
>         done
> -------------------- 8< -----------------------
>
>
> (Longer term, we would have to add support for subdirectories in
> general, i.e. not just the lang_subdirs, if more files would be moved
> from gcc/ to separate directories, e.g. all GIMPLE optimizations. But
> for now, one extra hard-coded directory is not a real problem, is it?)
>
>>
>> I have not yet otherwise reviewed the patch.
>
> Note that there is really not so *that* to review. I think the most
> important bits of the patch (and the hardest to keep in sync until the
> patch is approved) are the Makefile.in bits. Eventually I think there
> should be a separate Make* file in c-family/ but that is for a later
> patch (again, we'll need some form of support for subdirectories in
> general).

Btw, I guess it would be nice to delay the commit of this (and followp)
patches until after the gc-improv merge which is due on next Tuesday.

Richard.

> Ciao!
> Steven
>

Re: [patch] Move C front end to its own directory (1/3)

[Steven Bosscher]

On Sat, Jun 5, 2010 at 3:31 PM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> Btw, I guess it would be nice to delay the commit of this (and followp)
> patches until after the gc-improv merge which is due on next Tuesday.

Nice for who, exactly? Certainly not for me, thank you very much.

Ciao!
Steven

Re: [patch] Move C front end to its own directory (1/3)

[Richard Guenther]

On Sat, Jun 5, 2010 at 3:36 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Sat, Jun 5, 2010 at 3:31 PM, Richard Guenther
> <richard.guenther@gmail.com> wrote:
>> Btw, I guess it would be nice to delay the commit of this (and followp)
>> patches until after the gc-improv merge which is due on next Tuesday.
>
> Nice for who, exactly? Certainly not for me, thank you very much.

Nice for gc-improv.  I understand your patch is mostly svn mv.  OTOH
I would be not a bit surprised if svn merge wrecks your branch if there
are moves on the trunk.

Richard.

Re: [patch] Move C front end to its own directory (1/3)

[Steven Bosscher]

On Sat, Jun 5, 2010 at 3:42 PM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Sat, Jun 5, 2010 at 3:36 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
>> On Sat, Jun 5, 2010 at 3:31 PM, Richard Guenther
>> <richard.guenther@gmail.com> wrote:
>>> Btw, I guess it would be nice to delay the commit of this (and followp)
>>> patches until after the gc-improv merge which is due on next Tuesday.
>>
>> Nice for who, exactly? Certainly not for me, thank you very much.
>
> Nice for gc-improv.  I understand your patch is mostly svn mv.  OTOH
> I would be not a bit surprised if svn merge wrecks your branch if there
> are moves on the trunk.

And all checkins in c-* files and Makefile wreck my patch. It took
half a day to update the patch the other day, and that was just one
week of changes. There have been more checkins since than, and a few
proposed patches, that break my patch again.

I will update it one more time next week, then, but if it isn't
reviewed swiftly I will drop this work and move on to something more
interesting.

Ciao!
Steven

Re: [patch] Move C front end to its own directory (1/3)

[Laurynas Biveinis]

2010/6/5 Steven Bosscher <stevenb.gcc@gmail.com>:
>>>> Btw, I guess it would be nice to delay the commit of this (and followp)
>>>> patches until after the gc-improv merge which is due on next Tuesday.

Steven, go ahead and commit it. It will not cause much work for me to
update gc-improv before the merge.

-- 
Laurynas

Re: [patch] Move C front end to its own directory (1/3)

[Jason Merrill]

[-- Attachment #1: Type: text/plain, Size: 64 bytes --]

I have found that I need this additional patch.  Any objection?

[-- Attachment #2: c-family-tags.patch --]
[-- Type: text/x-patch, Size: 608 bytes --]

commit 543e778629a857bde16cd634b44974ec5b4d8413
Author: Jason Merrill <jason@redhat.com>
Date:   Tue Jun 8 16:13:11 2010 -0400

    	* Makefile.in (TAGS): Collect tags info from c-family.

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index a190225..806b4b1 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -4999,7 +4999,7 @@ TAGS: lang.tags
 	    incs="$$incs --include $$dir/TAGS.sub";	\
 	  fi;						\
 	done;						\
-	etags -o TAGS.sub *.h *.c; \
+	etags -o TAGS.sub c-family/*.h c-family/*.c *.h *.c; \
 	etags --include TAGS.sub $$incs)
 
 # -----------------------------------------------------

Re: [patch] Move C front end to its own directory (1/3)

[Jason Merrill]

[-- Attachment #1: Type: text/plain, Size: 64 bytes --]

I have found that I need this additional patch.  Any objection?

[-- Attachment #2: c-family-tags.patch --]
[-- Type: text/x-patch, Size: 608 bytes --]

commit 543e778629a857bde16cd634b44974ec5b4d8413
Author: Jason Merrill <jason@redhat.com>
Date:   Tue Jun 8 16:13:11 2010 -0400

    	* Makefile.in (TAGS): Collect tags info from c-family.

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index a190225..806b4b1 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -4999,7 +4999,7 @@ TAGS: lang.tags
 	    incs="$$incs --include $$dir/TAGS.sub";	\
 	  fi;						\
 	done;						\
-	etags -o TAGS.sub *.h *.c; \
+	etags -o TAGS.sub c-family/*.h c-family/*.c *.h *.c; \
 	etags --include TAGS.sub $$incs)
 
 # -----------------------------------------------------

Re: [patch] Move C front end to its own directory (1/3)

[Steven Bosscher]

On Tue, Jun 8, 2010 at 10:20 PM, Jason Merrill <jason@redhat.com> wrote:
> I have found that I need this additional patch.  Any objection?

Is hard-coding directory names necessary here? How does this work for
other subdirectories?

Ciao!
Steven

Re: [patch] Move C front end to its own directory (1/3)

[Jason Merrill]

On 06/08/2010 05:50 PM, Steven Bosscher wrote:
> On Tue, Jun 8, 2010 at 10:20 PM, Jason Merrill<jason@redhat.com>  wrote:
>> I have found that I need this additional patch.  Any objection?
>
> Is hard-coding directory names necessary here? How does this work for
> other subdirectories?

Other subdirectories have their Make-lang.in fragments generate a 
TAGS.sub file, and the main TAGS rule walks SUBDIRS collecting them.

Jason

Re: [patch] Move C front end to its own directory (1/3)

[Steven Bosscher]

On Tue, Jun 8, 2010 at 11:54 PM, Jason Merrill <jason@redhat.com> wrote:
> On 06/08/2010 05:50 PM, Steven Bosscher wrote:
>>
>> On Tue, Jun 8, 2010 at 10:20 PM, Jason Merrill<jason@redhat.com>  wrote:
>>>
>>> I have found that I need this additional patch.  Any objection?
>>
>> Is hard-coding directory names necessary here? How does this work for
>> other subdirectories?
>
> Other subdirectories have their Make-lang.in fragments generate a TAGS.sub
> file, and the main TAGS rule walks SUBDIRS collecting them.

OK, the plan is to pute the c-family/ Makefile bits in
c-family/Make-somename.in (and make this a general scheme for
subdirectories).  I'll remember to remove c-family again from
Makefile.in if/when that change is committed.

Ciao!
Steven

Re: [patch] Move C front end to its own directory (1/3)

[Joseph S. Myers]

On Tue, 8 Jun 2010, Jason Merrill wrote:

> I have found that I need this additional patch.  Any objection?

No objections from me.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [patch] Move C front end to its own directory (1/3)

[Mike Stump]

On May 29, 2010, at 2:28 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> This is the first patch of 3 planned, to move the C front end to its
> own directory.

> This first patch moves all the code common to the C-family of front
> ends to a new directory c-family/.

You forgot to clean up the built bits?!:

	* Makefile.in (mostlyclean): Remove c-family objects.

Index: Makefile.in
===================================================================
--- Makefile.in	(revision 204436)
+++ Makefile.in	(working copy)
@@ -2970,7 +2970,7 @@ gpl.pod: gpl_v3.texi
 
 mostlyclean: lang.mostlyclean
 	-rm -f $(MOSTLYCLEANFILES)
-	-rm -f *$(objext)
+	-rm -f *$(objext) c-family/*$(objext)
 	-rm -f *$(coverageexts)
 # Delete build programs
 	-rm -f build/*