From: Jakub Jelinek <jakub@redhat.com>
To: Richard Guenther <rguenther@suse.de>
Cc: Jan Hubicka <hubicka@ucw.cz>, gcc-patches@gcc.gnu.org
Subject: Re: Make gimple.h checks conditional with ENABLE_GIMPLE_CHECKING
Date: Wed, 09 Jun 2010 09:47:00 -0000 [thread overview]
Message-ID: <20100609093416.GE10293@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1006091122520.1429@zhemvz.fhfr.qr>
On Wed, Jun 09, 2010 at 11:22:59AM +0200, Richard Guenther wrote:
> Ok.
>
> Thanks,
> Richard.
>
> > Honza
> >
> > * gimple.h (set_bb_seq): Make check conditional with ENABLE_ChECKING.
s/ChECK/CHECK/.
And I have to agree with Manuel that it would be nice to introduce
gcc_checking_assert and gcc_gimple_checking_assert with
#ifdef ENABLE_CHECKING
#define gcc_checking_assert(EXPR) gcc_assert (EXPR)
#else
#define gcc_checking_assert(EXPR) ((void)(0 && (EXPR)))
#endif
and similar definitions to avoid too many #ifdefs all around.
> > (gimple_set_def_ops, gimple_set_use_ops,
> > gimple_set_vuse, gimple_set_vdef,
> > gimple_omp_subcode, gimple_omp_set_subcode, gimple_ops, gimple_op,
> > gimple_op_ptr, gimple_op_ptr, gimple_set_op, gimple_bind_set_block,
> > gimple_asm_input_op, gimple_asm_input_op_ptr, gimple_asm_set_input_op,
> > gimple_asm_output_op, gimple_asm_output_op_ptr,
> > gimple_asm_set_output_op, gimple_asm_clobber_op,
> > gimple_asm_set_clobber_op, gimple_asm_label_op,
> > gimple_asm_set_label_op, gimple_try_set_kind, gimple_try_catch_is_cleanup
> > gimple_try_set_catch_is_cleanup, gimple_phi_arg,
> > gimple_switch_num_labels, gimple_switch_set_index, gimple_switch_label,
> > gimple_switch_set_label, gimple_omp_for_index, gimple_omp_for_index_ptr,
> > gimple_omp_for_set_index, gimple_omp_for_initial, gimple_omp_for_initial_ptr,
> > gimple_omp_for_set_initial, gimple_omp_for_final, gimple_omp_for_final_ptr,
> > gimple_omp_for_set_final, gimple_omp_for_incr, gimple_omp_for_incr_ptr,
> > gimple_omp_for_set_incr, gimple_omp_for_set_cond, gimple_omp_for_cond): Make
> > checking conditional with ENABLE_GIMPLE_CHECKING.
> > (gimple_phi_set_arg): Likewise; replace memcpy by assignment.
Jakub
next prev parent reply other threads:[~2010-06-09 9:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 23:13 Jan Hubicka
2010-06-09 6:13 ` Basile Starynkevitch
2010-06-09 8:37 ` Manuel López-Ibáñez
2010-06-09 9:31 ` Richard Guenther
2010-06-09 9:29 ` Richard Guenther
2010-06-09 9:47 ` Jakub Jelinek [this message]
2010-06-09 11:15 ` Jan Hubicka
2010-06-09 11:25 ` Jakub Jelinek
2010-06-09 11:30 ` Richard Guenther
2010-06-09 10:05 ` Paolo Bonzini
2010-06-09 10:05 ` Laurynas Biveinis
2010-06-09 10:12 ` Paolo Bonzini
2010-06-09 10:50 ` Jan Hubicka
2010-06-09 11:14 ` Paolo Bonzini
2010-06-09 19:11 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100609093416.GE10293@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).