From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6931 invoked by alias); 9 Jun 2010 22:59:02 -0000 Received: (qmail 6916 invoked by uid 22791); 9 Jun 2010 22:59:01 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from ksp.mff.cuni.cz (HELO atrey.karlin.mff.cuni.cz) (195.113.26.206) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Jun 2010 22:58:55 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4018) id 281ECF017A; Thu, 10 Jun 2010 00:58:53 +0200 (CEST) Date: Wed, 09 Jun 2010 23:41:00 -0000 From: Jan Hubicka To: Jan Hubicka Cc: gcc-patches@gcc.gnu.org, rguenther@suse.de, gdr@integrable-solutions.net Subject: Re: Reorganize missing noreturn warning Message-ID: <20100609225853.GB15748@atrey.karlin.mff.cuni.cz> References: <20100601004003.GB28772@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100601004003.GB28772@kam.mff.cuni.cz> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-06/txt/msg01021.txt.bz2 > Hi, > this patch moves noreturn warning code to same infrastructure as const/pure. > This change wording of the warning by "might be possible candidat" to "might be > candidate" and supress the warning when compiler can do full auto detection > (i.e. for static functions, have patch for that in equeue). > > I added Wsuggest-attribute=noreturn and kept existing -Wmissing-noreturn as alias. > > Bootstrapped/regtested x86_64-linux, OK? > > Honza > > * doc/invoke.texi (Wsuggest-attribute): Document. > (Wmissing-noreturn): Remove. > * ipa-pure-const.c (warn_function_noreturn): New function. > * opts.c (decode_options): Set warn_suggest_attribute_noreturn on > warn_missing_noreturn. > * common.opt (Wsuggest-attribute=noreturn): New. > * tree-flow.h (warn_function_noreturn): Declare. > * tree-cfg.c (execute_warn_function_noreturn): Use > warn_function_noreturn. > (gate_warn_function_noreturn): New. > (pass_warn_function_noreturn): Update. > > * testsuite/gcc.dg/noreturn-7.c: Update. > * testsuite/gcc.dg/noreturn-4.c: Update. Ping...