public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nathan Froyd <froydnj@codesourcery.com>
To: Steve Ellcey <sje@cup.hp.com>
Cc: Mark Mitchell <mark@codesourcery.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH,c++] rewrite vtable initialization construction to use	VECs
Date: Wed, 16 Jun 2010 20:17:00 -0000	[thread overview]
Message-ID: <20100616180722.GF27105@codesourcery.com> (raw)
In-Reply-To: <1276708867.28515.66.camel@hpsje.cup.hp.com>

On Wed, Jun 16, 2010 at 10:21:07AM -0700, Steve Ellcey wrote:
> I finished a full bootstrap and test of the last patch you sent me and
> it looks good on IA64 HP-UX.

Thanks for doing this and bearing with me on the remote debugging.  I
have committed the patch below as r160856.

-Nathan

	* class.c (build_vtbl_initializer): Adjust computation of new_position
	and which entry to add padding for.

Index: class.c
===================================================================
--- class.c	(revision 160853)
+++ class.c	(working copy)
@@ -7607,14 +7607,15 @@ build_vtbl_initializer (tree binfo,
 	   ix--)
 	{
 	  int j;
-	  int new_position = TARGET_VTABLE_DATA_ENTRY_DISTANCE * ix;
+	  int new_position = (TARGET_VTABLE_DATA_ENTRY_DISTANCE * ix
+			      + (TARGET_VTABLE_DATA_ENTRY_DISTANCE - 1));
 
 	  VEC_replace (constructor_elt, vid.inits, new_position, e);
 
 	  for (j = 1; j < TARGET_VTABLE_DATA_ENTRY_DISTANCE; ++j)
 	    {
-	      constructor_elt *f = VEC_index (constructor_elt, *inits,
-					      new_position + j);
+	      constructor_elt *f = VEC_index (constructor_elt, vid.inits,
+					      new_position - j);
 	      f->index = NULL_TREE;
 	      f->value = build1 (NOP_EXPR, vtable_entry_type,
 				 null_pointer_node);
Index: ChangeLog
===================================================================

      reply	other threads:[~2010-06-16 18:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-23 17:54 Nathan Froyd
2010-05-24 16:20 ` Mark Mitchell
2010-06-03 20:47   ` Nathan Froyd
2010-06-10 17:12     ` Steve Ellcey
2010-06-15 13:50       ` Nathan Froyd
2010-06-15 17:44         ` Steve Ellcey
2010-06-15 18:41           ` Nathan Froyd
2010-06-15 21:01             ` Steve Ellcey
2010-06-15 21:03               ` Nathan Froyd
2010-06-16  6:14                 ` Steve Ellcey
2010-06-16 18:07                 ` Steve Ellcey
2010-06-16 20:17                   ` Nathan Froyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100616180722.GF27105@codesourcery.com \
    --to=froydnj@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mark@codesourcery.com \
    --cc=sje@cup.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).