public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Loren James Rittle <rittle@latour.labs.mot.com>
To: Gerald Pfeifer<gerald@pfeifer.com>
Cc: gcc-patches@gcc.gnu.org, ljrittle@motorola.com, avg@freebsd.org
Subject: Re: update -pthread specs for FreeBSD
Date: Wed, 29 Sep 2010 21:31:00 -0000	[thread overview]
Message-ID: <201009291640.o8TGeRrN092336@latour.labs.mot.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1009290446360.5068@acrux.dbai.tuwien.ac.at>	(message from Gerald Pfeifer on Wed, 29 Sep 2010 14:18:55 +0200	(CEST))

Approved.  Thank you for testing. -Loren

In article <alpine.LNX.2.00.1009290446360.5068@acrux.dbai.tuwien.ac.at>,
Gerald Pfeifer<gerald@pfeifer.com> writes:

> On Sat, 18 Sep 2010, Andriy Gapon wrote:
>>>> Please consider the attached patch that fixes what -pthread should 
>>>> expand too on modern version of FreeBSD. The patch is based on the 
>>>> changes that are made locally to a copy of GCC (4.2) in FreeBSD source 
>>>> tree: 
>>>> http://svn.freebsd.org/viewvc/base/head/contrib/gcc/config/freebsd-spec.h?revision=200038&view=markup

> I bootstrapped and tested Andriy's patch on amd64-unknown-freebsd8.1
> without regressions:

>   http://gcc.gnu.org/ml/gcc-testresults/2010-09/msg02492.html  (without)
>   http://gcc.gnu.org/ml/gcc-testresults/2010-09/msg02490.html  (with)

> (In fact, libgomp and libmudflap each lost warnings and failure,
> respectively, but I believe that was timing issues.)


> If approved, I can commit this to HEAD and the 4.5 branch.


> For the record, below the original patch with a ChangeLog of mine.

> Gerald


> 2010-09-29  Andriy Gapon <avg@freebsd.org>
 
> 	PR target/45808
> 	* config/freebsd-spec.h (FBSD_LIB_SPEC): Handle the shared case.

> --- gcc/config/freebsd-spec.h.orig	2010-09-13 14:35:06.151574339 +0300
> +++ gcc/config/freebsd-spec.h	2010-09-13 14:35:08.171465130 +0300
> @@ -139,6 +139,9 @@
>    %{!shared:								\
>      %{!pg: %{pthread:-lpthread} -lc}					\
>      %{pg:  %{pthread:-lpthread_p} -lc_p}				\
> +  }									\
> +  %{shared:								\
> +    %{pthread:-lpthread} -lc						\
>    }"
>  #endif
>  #endif

  reply	other threads:[~2010-09-29 16:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-18 18:27 Andriy Gapon
2010-09-18 19:43 ` Andriy Gapon
2010-09-18 21:24   ` Andriy Gapon
2010-09-29 17:34     ` Gerald Pfeifer
2010-09-29 21:31       ` Loren James Rittle [this message]
2011-02-14  4:17         ` Gerald Pfeifer
2011-02-26  1:42           ` Gerald Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009291640.o8TGeRrN092336@latour.labs.mot.com \
    --to=rittle@latour.labs.mot.com \
    --cc=avg@freebsd.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gerald@pfeifer.com \
    --cc=ljrittle@motorola.com \
    --cc=rittle@labs.mot.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).