From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5620 invoked by alias); 11 Oct 2010 14:54:33 -0000 Received: (qmail 5611 invoked by uid 22791); 11 Oct 2010 14:54:32 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Oct 2010 14:54:26 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 11 Oct 2010 07:54:24 -0700 X-ExtLoop1: 1 Received: from unknown (HELO localhost) ([10.255.16.15]) by fmsmga002.fm.intel.com with ESMTP; 11 Oct 2010 07:54:23 -0700 Date: Mon, 11 Oct 2010 14:54:00 -0000 From: Andi Kleen To: "Joseph S. Myers" Cc: Andi Kleen , gcc-patches@gcc.gnu.org, hubicka@ucw.cz Subject: Re: [PATCH 1/3] Add native ELF and LTO support in collect2 Message-ID: <20101011145646.GA9269@gargoyle.fritz.box> References: <1286792263-9244-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-10/txt/msg00915.txt.bz2 On Mon, Oct 11, 2010 at 02:33:07PM +0000, Joseph S. Myers wrote: > On Mon, 11 Oct 2010, Andi Kleen wrote: > > > Controlled by a define in the OS specific config file. > > I only enabled this on x86 Linux for now. > > OBJECT_FORMAT_ELF is already defined in elfos.h where it belongs (and in > several target-specific headers where it doesn't belong - some duplicating > the definition in elfos.h, others ELF targets that don't use elfos.h for > whatever reason). What do you suggest? Use a different name? > > > +#if !defined (HAVE_LIBELF_H) || !defined (HAVE_GELF_H) \ > > + || !defined (HAVE_UNISTD_H) || !defined (HAVE_FCNTL_H) \ > > + || defined (CROSS_DIRECTORY_STRUCTURE) > > Why the CROSS_DIRECTORY_STRUCTURE conditional? I wasn't sure if the host libelf works from cross compilation. Also some of the other elf format code had checks for it so I thought it was safer to exclude. -Andi