From: Jan Hubicka <hubicka@ucw.cz>
To: Michael Matz <matz@suse.de>
Cc: Jan Hubicka <hubicka@ucw.cz>, gcc-patches@gcc.gnu.org
Subject: Re: PR testsuite/45621 (indirect inlining related cgraph verifier ICE)
Date: Fri, 15 Oct 2010 16:16:00 -0000 [thread overview]
Message-ID: <20101015160856.GD21901@kam.mff.cuni.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.1010151419060.7602@wotan.suse.de>
> Hello,
>
> On Fri, 15 Oct 2010, Jan Hubicka wrote:
>
> > + 2010-10-14 Jan Hubicka <jh@suse.cz>
> > +
> > + PR middle-end/45621
> > + * cgraph.c (cgraph_update_edges_for_call_stmt_node): When new call is
> > + redirected to clone, be happy.
> > + * cgraph.h (cgraph node): Enable former_clone_of unconditinally.
> > + * cgraphunit.c (verify_cgraph_node, cgraph_materialize_clone): Handle
> > + former_clone_of unconditinally.
>
> With disable-checking this results in:
>
> libbackend.a(cgraphunit.o): In function `verify_cgraph_node':
> /gcc/spec/sb-frescobaldi.arch.suse.de-head-64/gcc/gcc/cgraphunit.c:659:
> undefined reference to `clone_of_p'
>
> for which I'm checking in the below as obvious.
Ah, thanks. Must've missed the hunk when separating patch out of my tree.
Honza
>
>
> Ciao,
> Michael.
> --
> * cgraphunit.c (clone_of_p): Define unconditionally.
>
> Index: cgraphunit.c
> ===================================================================
> --- cgraphunit.c (revision 165503)
> +++ cgraphunit.c (working copy)
> @@ -396,7 +396,6 @@ cgraph_mark_if_needed (tree decl)
> cgraph_mark_needed_node (node);
> }
>
> -#ifdef ENABLE_CHECKING
> /* Return TRUE if NODE2 is equivalent to NODE or its clone. */
> static bool
> clone_of_p (struct cgraph_node *node, struct cgraph_node *node2)
> @@ -405,7 +404,6 @@ clone_of_p (struct cgraph_node *node, st
> node2 = node2->clone_of;
> return node2 != NULL;
> }
> -#endif
>
> /* Verify edge E count and frequency. */
>
next prev parent reply other threads:[~2010-10-15 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 3:11 Jan Hubicka
2010-10-15 12:46 ` Michael Matz
2010-10-15 16:16 ` Jan Hubicka [this message]
2010-12-16 18:47 ` Martin Jambor
2010-12-16 19:44 ` Jan Hubicka
2010-12-23 16:54 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015160856.GD21901@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=matz@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).