From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24738 invoked by alias); 18 Oct 2010 17:02:21 -0000 Received: (qmail 24710 invoked by uid 22791); 18 Oct 2010 17:02:19 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-151-monday.nerim.net (HELO maiev.nerim.net) (194.79.134.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Oct 2010 17:02:15 +0000 Received: from hector.lesours (ours.starynkevitch.net [213.41.244.95]) by maiev.nerim.net (Postfix) with ESMTPS id 7108B2E01F; Mon, 18 Oct 2010 19:02:12 +0200 (CEST) Received: from glinka.lesours ([192.168.0.1] helo=glinka) by hector.lesours with smtp (Exim 4.72) (envelope-from ) id 1P7t6B-0004Vq-Td; Mon, 18 Oct 2010 19:02:11 +0200 Date: Mon, 18 Oct 2010 17:21:00 -0000 From: Basile Starynkevitch To: Basile Starynkevitch Cc: gcc-patches@gcc.gnu.org Subject: gengtype patch removing location_s Message-Id: <20101018190058.f77cb42c.basile@starynkevitch.net> In-Reply-To: <20100921211217.df1ef337.basile@starynkevitch.net> References: <20100921210301.d92889be.basile@starynkevitch.net> <20100921210829.5f2ea8b0.basile@starynkevitch.net> <20100921211217.df1ef337.basile@starynkevitch.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Mon__18_Oct_2010_19_00_58_+0200_aOYWd68CAMwZ528H" X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-10/txt/msg01538.txt.bz2 This is a multi-part message in MIME format. --Multipart=_Mon__18_Oct_2010_19_00_58_+0200_aOYWd68CAMwZ528H Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-length: 866 On Tue, 21 Sep 2010 21:12:17 +0200 Basile Starynkevitch wrote: http://gcc.gnu.org/ml/gcc-patches/2010-09/msg01709.html and Laurynas latter replied in http://gcc.gnu.org/ml/gcc-patches/2010-09/msg01742.html >> Since struct location_s is no longer used inside GCC, the hack in >> new_structure to handle it is removed. > This is excellent, but it really should be a separate patch. Here it is, against trunk 165645. ### gcc/ChangeLog entry ### 2010-10-18 Basile Starynkevitch * gengtype (new_structure): Remove ad-hoc "location_s" processing. ### Ok for trunk? -- Basile STARYNKEVITCH http://starynkevitch.net/Basile/ email: basilestarynkevitchnet mobile: +33 6 8501 2359 8, rue de la Faiencerie, 92340 Bourg La Reine, France *** opinions {are only mine, sont seulement les miennes} *** --Multipart=_Mon__18_Oct_2010_19_00_58_+0200_aOYWd68CAMwZ528H Content-Type: text/x-diff; name="gengtype-nolocation_s-rev165645.diff" Content-Disposition: attachment; filename="gengtype-nolocation_s-rev165645.diff" Content-Transfer-Encoding: 7bit Content-length: 740 Index: gcc/gengtype.c =================================================================== --- gcc/gengtype.c (revision 165645) +++ gcc/gengtype.c (working copy) @@ -756,20 +756,6 @@ new_structure (const char *name, int isunion, stru if (s->u.s.lang_struct) s->u.s.lang_struct->u.s.bitmap |= bitmap; - /* Reset location_s's location to input.h so that we know where to - write out its mark routine. */ - if (!strcmp (name, "location_s") && !isunion && pos->file == this_file) - { - size_t n; - for (n = 0; n < num_gt_files; n++) - if (!strcmp (gt_files[n] + strlen (gt_files[n]) - strlen ("input.h"), - "input.h")) - { - s->u.s.line.file = gt_files[n]; - break; - } - } - return s; } --Multipart=_Mon__18_Oct_2010_19_00_58_+0200_aOYWd68CAMwZ528H--