From: Eric Botcazou <ebotcazou@adacore.com>
To: Jie Zhang <jie@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Don't combine instructions if they can't be copied
Date: Sat, 23 Oct 2010 16:16:00 -0000 [thread overview]
Message-ID: <201010231656.08801.ebotcazou@adacore.com> (raw)
In-Reply-To: <4CC1017C.1060302@codesourcery.com>
> With this patch, GCC will not combine instructions if they can't be
> copied. Tested on arm-linux-gnueabi with c,c++,lto. No regressions are
> found.
>
> Is it OK?
From the above description, as well as the ChangeLog, I would have said no,
this is too broad. But the implementation is actually more fine-grained and
looks sensible to me. So OK for mainline if (1) you add a comment to the code
explaining its purpose, e.g. "We are about to copy insns for the case where
they need to be kept around. Check that..." and (2) you fix the ChangeLog.
No need to resubmit.
--
Eric Botcazou
next prev parent reply other threads:[~2010-10-23 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 7:51 Jie Zhang
2010-10-23 16:16 ` Eric Botcazou [this message]
2010-10-25 13:00 ` Jie Zhang
2010-10-25 14:55 ` Jie Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010231656.08801.ebotcazou@adacore.com \
--to=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jie@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).