public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Zdenek Dvorak <rakdver@kam.mff.cuni.cz>
To: Xinliang David Li <davidxl@google.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Fix PR/46200 -- ivopt bug in test condition cost computation
Date: Sun, 31 Oct 2010 09:22:00 -0000	[thread overview]
Message-ID: <20101030193016.GA20982@kam.mff.cuni.cz> (raw)
In-Reply-To: <AANLkTi=TiOqvQsCGUwAP+BdYuNKoXkMR+bUPAJ3LP=8d@mail.gmail.com>

Hi,

> Hi, please review the patch attached. Regression and some performance
> test is under going.

it would be more consistent to either avoid using aff_combination functions
in get_computation_cost_at completely, or rewrite it to use aff_combination
instead of the current difference_cost/... functions (however, the latter
would probably lead to somewhat slower compilation time).  The patch should
also include a testcase for the problem.

Thanks for working on this,

Zdenek

  reply	other threads:[~2010-10-30 19:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29 23:10 Xinliang David Li
2010-10-31  9:22 ` Zdenek Dvorak [this message]
2010-11-01  6:59   ` Xinliang David Li
2010-11-02 17:15     ` Xinliang David Li
2010-11-03 10:28     ` Zdenek Dvorak
2010-11-03 23:10       ` Xinliang David Li
2010-11-05 20:40 ` H.J. Lu
2010-11-05 20:42   ` H.J. Lu
2010-11-05 21:00     ` H.J. Lu
2010-11-06 11:08   ` Xinliang David Li
2010-11-07 21:29   ` Xinliang David Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101030193016.GA20982@kam.mff.cuni.cz \
    --to=rakdver@kam.mff.cuni.cz \
    --cc=davidxl@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).