Re: PATCH RFA: Build machinery: Autoconf support for Go

[Ralf Wildenhues <Ralf.Wildenhues@gmx.de>]

Hello Ian,

* Ian Lance Taylor wrote on Wed, Nov 03, 2010 at 09:21:04PM CET:
> This patch adds a new file config/go.m4, which provides autoconf support
> for Go.  This file is not used by anything at present, but it will be
> used by the libgo library configure script when that is committed.  A
> version of this file has been proposed to the autoconf maintainers.
> When gcc moves to a version of autoconf which includes Go support, this
> file can be deleted.  However, until that time, it is useful for libgo.
> Putting it in a separate file means that the libgo configure script
> itself most likely will not have to be changed when we move to a new
> version of autoconf.
> 
> Bootstrapped on x86_64-unknown-linux-gnu.  OK for mainline?

I cannot approve this (yet), but it looks OK except for a couple of
nits: I'd wrap the contents in m4_version_prereq([2.69],, [...])
so that they turn into a no-op once the code has been integrated into
Autoconf (assuming for the moment that this will hapenn before 2.69),
similarly to how we treat additions to config/override.m4.  You could
also have added the code to that file, that would've avoided any further
dependencies of generated aclocal.m4 and configure files (and in
directories using AC_PROG_GO but not using automake the dependency on
config/go.m4 will need to be tracked manually in Makefile.in).  OTOH
the size of this warrants a new file for clarity.

I'm assuming that the macro definitions here are in sync with those
posted on autoconf-patches.

Thanks,
Ralf

> 2010-11-03  Ian Lance Taylor  <iant@google.com>
> 
> 	* go.m4: New file.
> 
>