From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30503 invoked by alias); 12 Nov 2010 15:07:46 -0000 Received: (qmail 30448 invoked by uid 22791); 12 Nov 2010 15:07:46 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from lo.gmane.org (HELO lo.gmane.org) (80.91.229.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Nov 2010 15:07:03 +0000 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PGvDO-0005D3-7x for gcc-patches@gcc.gnu.org; Fri, 12 Nov 2010 16:06:58 +0100 Received: from s209p8.home.99maxprogres.cz ([85.93.118.17]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 12 Nov 2010 16:06:58 +0100 Received: from bonzini by s209p8.home.99maxprogres.cz with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 12 Nov 2010 16:06:58 +0100 To: gcc-patches@gcc.gnu.org From: Paolo Bonzini Subject: Re: Ping^2: RFA (build): Avoid circular dependency Date: Fri, 12 Nov 2010 15:59:00 -0000 Message-ID: <4CDD5805.8040708@gnu.org> References: <20100629172139.7sxigvan4g48koss-nzlynne@webmail.spamcop.net> <20101104090834.yzg2549rks8o84wg-nzlynne@webmail.spamcop.net> <20101112091310.xfc3pvh9ogw0sskg-nzlynne@webmail.spamcop.net> <4CDD502D.9060405@gnu.org> <20101112100204.lhw5uyhrpcswogo8-nzlynne@webmail.spamcop.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: gcc-patches@gcc.gnu.org, DJ Delorie , Alexandre Oliva User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Fedora/3.1.6-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6 In-Reply-To: <20101112100204.lhw5uyhrpcswogo8-nzlynne@webmail.spamcop.net> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-11/txt/msg01299.txt.bz2 Message-ID: <20101112155900.P1BJrzVCylUV3xMEv4YTCVJ-Bw4bBRHbFwTJbgRglGM@z> On 11/12/2010 04:02 PM, Joern Rennecke wrote: > Quoting Paolo Bonzini : > >> On 11/12/2010 03:13 PM, Joern Rennecke wrote: > ... >>> Are you still planning to do the review in the near future? >> >> Yes. Your patch has the disadvantage that a normal "make" will not >> do the check anymore, because you removed the dependency from all to >> s-tm-texi (which previously went all -> info -> gccint.info -> >> tm.texi -> s-tm-texi). > > We still have a gccint.info -> new-tm.texi -> s-tm-texi link. Ok, I missed the last hunk. That is unfortunately wrong because you would force people who compile a release tarball to run makeinfo (because new-tm.texi) is not shipped. I think your patch can be okay if you leave TEXI_GCCINT_FILES aside, and put an additional dependency @MAINT@ all: new-tm.texi Paolo