From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18928 invoked by alias); 22 Nov 2010 08:43:05 -0000 Received: (qmail 18920 invoked by uid 22791); 22 Nov 2010 08:43:05 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_ZJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Nov 2010 08:43:00 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAM8gw4d017209 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 22 Nov 2010 03:42:59 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oAM8gwOn002746 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Nov 2010 03:42:58 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id oAM8gveX019320; Mon, 22 Nov 2010 09:42:57 +0100 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id oAM8gvTm019319; Mon, 22 Nov 2010 09:42:57 +0100 Date: Mon, 22 Nov 2010 09:51:00 -0000 From: Jakub Jelinek To: Uros Bizjak Cc: Richard Guenther , gcc-patches@gcc.gnu.org Subject: Re: [PATCH, middle-end]: Fix PR 43057, [LTO] fold check: original tree changed by fold Message-ID: <20101122084257.GN29412@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <20101121211307.GM29412@tyan-ft48-01.lab.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-11/txt/msg02227.txt.bz2 On Mon, Nov 22, 2010 at 09:34:11AM +0100, Uros Bizjak wrote: > Your proposed approach also works (and fixes bootstrap with > --enable-checking=all, too). If there are no objections from Richi, I > propose to commit this change to mainline (since it enables bootstrap > with --enable-checking=fold) and fix all fold fails from the testsuite > separately. Fine with me; if Richi agrees to that, it would be better to put this into a separate inline (fold-const.c local is ok) though, as it might be used later on in multiple locations. And then at the next phase get rid of all the protected_set_expr_location and SET_EXPR_LOCATION uses in fold-const.c, either (when used on the result of buildN), start using buildN_loc, or call this new inline instead. Jakub