From: Jack Howarth <howarth@bromo.med.uc.edu>
To: gcc-patches@gcc.gnu.org
Cc: joseph@codesourcery.com, Ralf.Wildenhues@gmx.de
Subject: [PATCH,, PR46650][Revised] Fix --enable-build-with-cxx bootstrap failure
Date: Sun, 28 Nov 2010 13:28:00 -0000 [thread overview]
Message-ID: <20101128030344.GA23135@bromo.med.uc.edu> (raw)
Currently the --enable-build-with-cxx bootstrap is broken due to r167010
which poisoned the strerror macro. The attached patch includes the cstring c++
header when __cplusplus is defined. The previous includes for string.h and
strings.h are left in place for symbols like strcasecmp. Bootstrap and
regression tested on x86_64-apple-darwin10.
http://gcc.gnu.org/ml/gcc-testresults/2010-11/msg02329.html
Okay for gcc trunk?
Jack
2010-11-27 Jack Howarth <howarth@bromo.med.uc.edu>
Joseph Myers <joseph@codesourcery.com>
PR bootstrap/46650
* gcc/system.h: Include cstring for cxx bootstrap.
Index: gcc/system.h
===================================================================
--- gcc/system.h (revision 167217)
+++ gcc/system.h (working copy)
@@ -194,6 +194,10 @@
rely on (and therefore test) GCC's string builtins. */
#define __NO_STRING_INLINES
+#ifdef __cplusplus
+# include <cstring>
+#endif
+
#ifdef STRING_WITH_STRINGS
# include <string.h>
# include <strings.h>
next reply other threads:[~2010-11-28 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 13:28 Jack Howarth [this message]
2010-11-28 13:51 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101128030344.GA23135@bromo.med.uc.edu \
--to=howarth@bromo.med.uc.edu \
--cc=Ralf.Wildenhues@gmx.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).