public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: John David Anglin <dave@hiauly1.hia.nrc.ca>
To: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org
Subject: [patch libgfortran] path to libquadmath
Date: Mon, 29 Nov 2010 00:13:00 -0000	[thread overview]
Message-ID: <20101128204243.GA2551@hiauly1.hia.nrc.ca> (raw)

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

The current relative path to libquadmath can be incorrectly interpreted
on systems that hard code library paths.  In particular, on 32-bit
hppa*-*hpux*, the '..' part of the path is relative to the final executable.
As a result, all libgfortran tests fail due to a dynamic loader error.

The patch changes the path to an absolute path.

Tested on hppa2.0w-hp-hpux11.11 and i686-apple-darwin9 with no observed
regressions.

OK for trunk?

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)

[-- Attachment #2: acinclude.m4.d --]
[-- Type: text/plain, Size: 1117 bytes --]

2010-11-28  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>

	* acinclude.m4 (LIBQUADLIB): Use absolute path.
	* configure: Rebuild.

Index: configure
===================================================================
--- configure	(revision 167224)
+++ configure	(working copy)
@@ -24396,7 +24396,7 @@
       LIBQUADSPEC="-lquadmath"
     fi
     if test -f ../libquadmath/libquadmath.la; then
-      LIBQUADLIB=../libquadmath/libquadmath.la
+      LIBQUADLIB='$(abs_builddir)/../libquadmath/libquadmath.la'
       LIBQUADLIB_DEP=../libquadmath/libquadmath.la
       LIBQUADINCLUDE='-I$(srcdir)/../libquadmath'
     else
Index: acinclude.m4
===================================================================
--- acinclude.m4	(revision 167224)
+++ acinclude.m4	(working copy)
@@ -332,7 +332,7 @@
       LIBQUADSPEC="-lquadmath"
     fi
     if test -f ../libquadmath/libquadmath.la; then
-      LIBQUADLIB=../libquadmath/libquadmath.la
+      LIBQUADLIB='$(abs_builddir)/../libquadmath/libquadmath.la'
       LIBQUADLIB_DEP=../libquadmath/libquadmath.la
       LIBQUADINCLUDE='-I$(srcdir)/../libquadmath'
     else

             reply	other threads:[~2010-11-28 20:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-29  0:13 John David Anglin [this message]
2010-11-29  0:58 ` Ralf Wildenhues
2010-11-29  1:50   ` John David Anglin
2010-12-06  0:57   ` John David Anglin
2010-12-10 17:03   ` John David Anglin
2010-12-19 16:21     ` ping: [PATCH libtool] hardcoded path to dependent shared libraries on 32-bit hpux (libquadmath) John David Anglin
2010-12-19 19:35       ` Ralf Wildenhues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101128204243.GA2551@hiauly1.hia.nrc.ca \
    --to=dave@hiauly1.hia.nrc.ca \
    --cc=dave.anglin@nrc-cnrc.gc.ca \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).