public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nathan Froyd <froydnj@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Jason Merrill <jason@redhat.com>,
	gcc-patches@gcc.gnu.org,	mark@codesourcery.com,
	libstdc++@gcc.gnu.org
Subject: Re: [RFC,c++] fix PR 45329, provide information on overload resolution
Date: Thu, 09 Dec 2010 05:49:00 -0000	[thread overview]
Message-ID: <20101209042357.GG25904@nightcrawler> (raw)
In-Reply-To: <AANLkTime5=5Y7_6KE=QFxtsQMbe-R5zG-eHBor1a4T37@mail.gmail.com>

On Wed, Dec 08, 2010 at 04:32:39PM -0800, H.J. Lu wrote:
> On Wed, Dec 8, 2010 at 6:58 AM, Nathan Froyd <froydnj@codesourcery.com> wrote:
> > gcc/cp/
> >        PR c++/45329
> 
> This caused:
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46860

Oops.  Sorry about that.  Here's a patch to fix the overlooked libstdc++
test cases.

Tested on x86_64-unknown-linux-gnu.  OK to commit?

-Nathan

libstdc++-v3/
	PR testsuite/46860
	* testsuite/20_util/auto_ptr/assign_neg.cc: Adjust.
	* testsuite/20_util/unique_ptr/assign/assign_neg.cc: Adjust.
	* testsuite/20_util/weak_ptr/comparison/cmp_neg.cc: Adjust.

diff --git a/libstdc++-v3/testsuite/20_util/auto_ptr/assign_neg.cc b/libstdc++-v3/testsuite/20_util/auto_ptr/assign_neg.cc
index 1f6e673..0fea060 100644
--- a/libstdc++-v3/testsuite/20_util/auto_ptr/assign_neg.cc
+++ b/libstdc++-v3/testsuite/20_util/auto_ptr/assign_neg.cc
@@ -37,6 +37,7 @@ test01()
 {
   std::auto_ptr<Base> ptr2;
   ptr2 = new Base; // { dg-error "no match" }
+  // { dg-error "candidate" "candidate note" { target *-*-* } 39 }
   return 0;
 }
 
@@ -46,6 +47,6 @@ main()
   test01();
   return 0;
 }
-// { dg-error "candidates" "" { target *-*-* } 134 } 
+// { dg-error "::auto_ptr|no known conversion" "" { target *-*-* } 134 } 
 // { dg-error "note" "" { target *-*-* } 152 }
-// { dg-error "::auto_ptr" "" { target *-*-* } 262 } 
+// { dg-error "::auto_ptr|no known conversion" "" { target *-*-* } 262 } 
diff --git a/libstdc++-v3/testsuite/20_util/unique_ptr/assign/assign_neg.cc b/libstdc++-v3/testsuite/20_util/unique_ptr/assign/assign_neg.cc
index 95c1d5d..501bad3 100644
--- a/libstdc++-v3/testsuite/20_util/unique_ptr/assign/assign_neg.cc
+++ b/libstdc++-v3/testsuite/20_util/unique_ptr/assign/assign_neg.cc
@@ -46,6 +46,7 @@ void
 test03()
 {
   std::unique_ptr<int[2]> p1(new int[3]); // { dg-error "no match" }
+  // { dg-error "candidate" "candidate-note" { target *-*-* } 48 }
   std::unique_ptr<int[2]> p2 = p1; // { dg-error "deleted" }
 }
 
diff --git a/libstdc++-v3/testsuite/20_util/weak_ptr/comparison/cmp_neg.cc b/libstdc++-v3/testsuite/20_util/weak_ptr/comparison/cmp_neg.cc
index 019f5f7..c26b09d 100644
--- a/libstdc++-v3/testsuite/20_util/weak_ptr/comparison/cmp_neg.cc
+++ b/libstdc++-v3/testsuite/20_util/weak_ptr/comparison/cmp_neg.cc
@@ -31,6 +31,7 @@ test01()
 {
   std::weak_ptr<A> p1;
   p1 < p1;  // { dg-error "no match" }
+  // { dg-error "candidate" "candidate note" { target *-*-* } 33 }
   return 0;
 }
 

  reply	other threads:[~2010-12-09  4:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 21:32 Nathan Froyd
2010-11-18  8:12 ` Mark Mitchell
2010-11-19 23:31 ` Jason Merrill
2010-11-19 23:52   ` Jason Merrill
2010-11-20  1:39   ` Mark Mitchell
2010-12-02 22:10   ` Nathan Froyd
2010-12-03 16:59     ` Jason Merrill
2010-12-08 15:13       ` Nathan Froyd
2010-12-08 19:45         ` Mark Mitchell
2010-12-09  3:10         ` H.J. Lu
2010-12-09  5:49           ` Nathan Froyd [this message]
2010-12-09  5:51             ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101209042357.GG25904@nightcrawler \
    --to=froydnj@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=jason@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=mark@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).