From: John David Anglin <dave@hiauly1.hia.nrc.ca>
To: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>,
gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org
Cc: libtool-patches@gnu.org
Subject: Re: [patch libgfortran] path to libquadmath
Date: Fri, 10 Dec 2010 17:03:00 -0000 [thread overview]
Message-ID: <20101210165825.GA28835@hiauly1.hia.nrc.ca> (raw)
In-Reply-To: <20101128205655.GO2003@gmx.de>
On Sun, 28 Nov 2010, Ralf Wildenhues wrote:
> * John David Anglin wrote on Sun, Nov 28, 2010 at 09:42:43PM CET:
> > The current relative path to libquadmath can be incorrectly interpreted
> > on systems that hard code library paths. In particular, on 32-bit
> > hppa*-*hpux*, the '..' part of the path is relative to the final executable.
> > As a result, all libgfortran tests fail due to a dynamic loader error.
> >
> > The patch changes the path to an absolute path.
> >
> > Tested on hppa2.0w-hp-hpux11.11 and i686-apple-darwin9 with no observed
> > regressions.
> >
> > OK for trunk?
>
> That doesn't seem to make sense to me. The fix should be in ltmain.sh
> or in libtool.m4. Please post the output of how libquadmath is linked
> on your system (the 'libtool --mode=link' command plus all of its
> output).
The attached change to ltmain.sh fixes the above problem on on 32-bit
hppa*-*hpux*. Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.
Would you please apply if ok to libtool, gcc and sourceware?
Thanks,
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
2010-12-10 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
* ltmain.sh (relink): Use absolute path when hardcoding with -L.
Index: ltmain.sh
===================================================================
--- ltmain.sh (revision 167668)
+++ ltmain.sh (working copy)
@@ -5928,7 +5928,7 @@
test "$hardcode_direct_absolute" = no; then
add="$dir/$linklib"
elif test "$hardcode_minus_L" = yes; then
- add_dir="-L$dir"
+ add_dir="-L$absdir"
# Try looking first in the location we're being installed to.
if test -n "$inst_prefix_dir"; then
case $libdir in
next prev parent reply other threads:[~2010-12-10 16:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 0:13 John David Anglin
2010-11-29 0:58 ` Ralf Wildenhues
2010-11-29 1:50 ` John David Anglin
2010-12-06 0:57 ` John David Anglin
2010-12-10 17:03 ` John David Anglin [this message]
2010-12-19 16:21 ` ping: [PATCH libtool] hardcoded path to dependent shared libraries on 32-bit hpux (libquadmath) John David Anglin
2010-12-19 19:35 ` Ralf Wildenhues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210165825.GA28835@hiauly1.hia.nrc.ca \
--to=dave@hiauly1.hia.nrc.ca \
--cc=Ralf.Wildenhues@gmx.de \
--cc=dave.anglin@nrc-cnrc.gc.ca \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=libtool-patches@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).